refactor: fix clippy warnings

src/config.rs

@@ -125,9 +125,9 @@ impl Config {
         };
 
         let mut config = Self {
+            env,
             base_url,
             schema_location,
-            env,
             http,
             database,
         };

src/db/mod.rs

@@ -29,7 +29,7 @@ pub async fn connect(database: &config::Database) -> Result<DB, Error> {
 
 pub async fn migrate(db: &DB) -> Result<(), Error> {
     match sqlx::migrate!("db/migrations").run(db).await {
-        Ok(_) => Ok(()),
+        Ok(()) => Ok(()),
         Err(err) => {
             tracing::error!("{}", &err);
             Err(err)

src/domain/user/repository/find_all_users.rs

@@ -35,7 +35,7 @@ impl Repository {
             }
             // Last & before
             (None, None, Some(last), Some(before)) => {
-                query = format!("select * from ( select * from user_ where id < '{before}' order by id desc limit {limit} ) as data order by id asc;", limit = last + 1)
+                query = format!("select * from ( select * from user_ where id < '{before}' order by id desc limit {limit} ) as data order by id asc;", limit = last + 1);
             }
             // Default page size
             _ => query = format!("{query} limit {default_page_size}"),
@@ -65,20 +65,20 @@ impl Repository {
     }
     pub async fn has_previous_page(
         &self,
-        rows: &Vec<entities::User>,
+        rows: &[entities::User],
         last: Option<i32>,
     ) -> Result<bool, Error> {
         let mut has_previous_page: bool = false;
         if let Some(last) = last {
             tracing::debug!("rows length: {}. last: {}", rows.len(), last);
-            has_previous_page = rows.len() > last as usize
+            has_previous_page = rows.len() > last as usize;
         };
         Ok(has_previous_page)
     }
     pub async fn find_page_info<'c, C: Queryer<'c> + Copy>(
         &self,
         db: C,
-        rows: &Vec<entities::User>,
+        rows: &[entities::User],
         first: Option<i32>,
         after: Option<Uuid>,
         last: Option<i32>,
@@ -122,20 +122,20 @@ impl Repository {
             };
         };
 
-        let (start_cursor, end_cursor) = if !rows.is_empty() {
+        let (start_cursor, end_cursor) = if rows.is_empty() {
+            (None, None)
+        } else {
             let start_cursor = Base64Cursor::new(rows[0].id).encode();
             let end_cursor = Base64Cursor::new(rows[rows.len() - 1].id).encode();
             (Some(start_cursor), Some(end_cursor))
-        } else {
-            (None, None)
         };
 
         let has_previous_page = self.has_previous_page(rows, last).await?;
         let page_info = entities::PageInfo {
+            end_cursor,
             has_next_page,
-            has_previous_page,
             start_cursor,
-            end_cursor,
+            has_previous_page,
         };
 
         Ok(page_info)

src/domain/user/resolver.rs

@@ -27,7 +27,7 @@ impl UserQuery {
             .await?;
         let edges: Vec<model::UserEdge> = user_edges
             .into_iter()
-            .map(|user| user.transmogrify())
+            .map(frunk::labelled::Transmogrifier::transmogrify)
             .collect();
 
         let user_connection = model::UserConnection {

src/domain/user/service/mod.rs

@@ -22,7 +22,7 @@ pub struct Service {
 impl Service {
     pub fn new(db: DB, mailer: Mailer) -> Self {
         let repo = Repository::new();
-        Self { db, repo, mailer }
+        Self { repo, db, mailer }
     }
 }
 

src/relay/mod.rs

@@ -48,7 +48,7 @@ impl Base64Cursor {
         let index = cursor
             .split(':')
             .last()
-            .map(|s| s.parse::<Uuid>())
+            .map(str::parse)
             .ok_or(Base64CursorError::Invalid)?
             .map_err(|_| Base64CursorError::Invalid)?;