improve startup performance (DAT-18327) (liquibase#6366)

b-gyula · Oct 10, 2024 · 946f4e4 · 946f4e4
1 parent d1dcdde
commit 946f4e4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/liquibase-cli/src/main/java/liquibase/integration/commandline/LiquibaseCommandLine.java b/liquibase-cli/src/main/java/liquibase/integration/commandline/LiquibaseCommandLine.java
@@ -898,6 +898,7 @@ protected ClassLoader configureClassLoader() throws IllegalArgumentException {
 
     private void addSubcommand(CommandDefinition commandDefinition, CommandLine rootCommand) {
         List<String[]> commandNames = expandCommandNames(commandDefinition);
+        Boolean showHidden = LiquibaseCommandLineConfiguration.SHOW_HIDDEN_ARGS.getCurrentValue();
 
         boolean showCommand = true;
         for (String[] commandName : commandNames) {
@@ -991,7 +992,7 @@ private void addSubcommand(CommandDefinition commandDefinition, CommandLine root
                     if (i > 0) {
                         builder.hidden(true);
                     } else {
-                        builder.hidden(def.getHidden() && !LiquibaseCommandLineConfiguration.SHOW_HIDDEN_ARGS.getCurrentValue());
+                        builder.hidden(def.getHidden() && !showHidden);
                     }
 
                     subCommandSpec.addOption(builder.build());

diff --git a/...e-standard/src/main/java/liquibase/command/core/helpers/AbstractChangelogCommandStep.java b/...e-standard/src/main/java/liquibase/command/core/helpers/AbstractChangelogCommandStep.java
@@ -8,7 +8,6 @@
 import liquibase.command.CommandBuilder;
 import liquibase.command.CommandScope;
 import liquibase.exception.CommandValidationException;
-import org.apache.commons.lang3.StringUtils;
 
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -33,7 +32,7 @@ public abstract class AbstractChangelogCommandStep extends AbstractCommandStep {
                 .defaultValue("none").description("Sets runOnChange=\"true\" for changesets containing solely changes of these types (e. g. createView, createProcedure, ...).").build();
         REPLACE_IF_EXISTS_TYPES_ARG = builder.argument("replaceIfExistsTypes", String.class)
                 .defaultValue("none")
-                .description(String.format("Sets replaceIfExists=\"true\" for changes of these types (supported types: %s)", StringUtils.join(REPLACE_IF_EXISTS_TYPES_NAMES, ", "))).build();
+                .description("Sets replaceIfExists=\"true\" for changes of these types (supported types: createProcedure, createView)").build();
         SKIP_OBJECT_SORTING = builder.argument("skipObjectSorting", Boolean.class)
                 .defaultValue(false)
                 .description("When true will skip object sorting. This can be useful on databases that have a lot of packages/procedures that are " +
@@ -56,7 +55,7 @@ protected static void validateReplaceIfExistsTypes(final CommandScope commandSco
         supportedReplaceIfExistsTypes.add("none");
         replaceIfExistsTypes.removeAll(supportedReplaceIfExistsTypes);
         if (!replaceIfExistsTypes.isEmpty())
-            throw new CommandValidationException("Invalid types for --replace-if-exists-types: " + replaceIfExistsTypes.stream().collect(Collectors.joining(", ")));
+            throw new CommandValidationException("Invalid types for --replace-if-exists-types: " + replaceIfExistsTypes.stream().collect(Collectors.joining(", ")) + ". Valid types are: " + REPLACE_IF_EXISTS_TYPES_NAMES.stream().collect(Collectors.joining(", ")));
     }
 
     protected static Stream<String> supportedRunOnChangeTypes() {

diff --git a/liquibase-standard/src/main/java/liquibase/util/StringUtil.java b/liquibase-standard/src/main/java/liquibase/util/StringUtil.java
@@ -790,11 +790,12 @@ public static String toKabobCase(String string) {
             return null;
         }
 
-        if (string.length() == 1) {
+        int length = string.length();
+        if (length == 1) {
             return string;
         }
 
-        StringBuilder outString = new StringBuilder();
+        StringBuilder outString = new StringBuilder(length);
         char[] charString = string.toCharArray();
         for (int i = 0; i < charString.length; i++) {
             char letter = charString[i];