-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tf1.15/deep galaxy model #16
base: gaussiansinf
Are you sure you want to change the base?
Conversation
For the illustration, here are some plots using the tf-1.15 version of the code: For longer chains, see #11 (comment) |
A simple first task to test the Generating observations with the
Note that I don't fit the centroid here. It looks like there is a very few residuals when optimizing on the latent variable :-) However, I was not able to use
Maybe you know the right way to import the models within TensorFlow graphs @EiffL ? |
…gems into tf1.15/deep_galaxy_model
It turns out we can use edward2 within Tensorflow Probability (0.7.0) compatible with TensorFlow 1.15. So I was able to run the latests scripts after a few updates of the code :-)
Thanks to this, I think that there is no need to change the PPL to tfp.JointDistributionCoroutine since I am used to edward2 and everything seems compatible.
I can now shift to the deep morphological model using the same framework as before.
This is still a draft pull request, I don't really know how to merge this since there is still a lot of TF2 code in the repo... Here is the code already converted to TF 1.15 (and tfp==0.7.0), compared to the latest version of the code (https://github.com/b-remy/gems/tree/gaussiansinf , ab506ca)
gems/models.py
sersic_model
sersic_model_cosmos
gaussian_model
varying_shear_gaussian_model
(just needs to update the interpolator)sersic2morph_model
gems/ed_utils.py
gems/shear.py
gems/utils.py
scripts
cosmo_shear_paramtric.py
cosmo_shear_real.py
simpler_model.py
varying_shear_gaussians.py
Also note that it requires to install GalFlow from https://github.com/b-remy/GalFlow/tree/tf1