Skip to content

FEATURE: Allow for configurable site package prefix #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sorenmalling
Copy link

The newly introduced extension configuration allows to change the site package prefix.

By default it's value is site_. Changing this, will only have effect for displayed items in the list of site configuration module.

Resolves: #43

The newly introduced extension configuration allows to change the site package prefix.

By default it's value is site_. Changing this, will only have effect for displayed
items in the list of site configuration module.
@bmack
Copy link
Member

bmack commented Feb 16, 2024

Let's just remove this check alltogether

@sorenmalling
Copy link
Author

Let's just remove this check alltogether

And change the field to a simple string? List all packages?

I like the idea of separating packages responsible for rendering, hence my proposal

@sorenmalling
Copy link
Author

Alternative, mentions in the documentation how you add a extra entry to the site configuration by using SiteConfiguration overrides

@bmack
Copy link
Member

bmack commented Feb 18, 2024

I'm not in favor of adding configuration options :) TYPO3 already has tons of them. We could alternatively

  • add more "common" prefixes or suffixes by default
  • check for a specific string in the extension title?

@sorenmalling
Copy link
Author

* add more "common" prefixes or suffixes by default

For reference, our uncommon prefix of packages in charge of rendering is ucph_layout_ 😄

How about this, read the

    "extra": {
        "typo3/cms": {

        }
    }
}

part and look for site-package: true ?

@sorenmalling
Copy link
Author

It could require a extension of the Package MetaData class, to contain the "extra" part, for a clean access to that data.

@sorenmalling
Copy link
Author

Our, use a

  "type": "typo3-cms-site"

and use the already available $packageType - boom 🚀

I can provide a PR with a working example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for different strategies to get list of extension to use for site package
2 participants