[TASK] Add PHP 7.2 compatability

The lint task not ignores files in "Resources/Private/CodeTemplates/"
b13 · Apr 29, 2022 · ce30c46 · ce30c46
1 parent 1a70405
commit ce30c46
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/Build/testing-docker/docker-compose.yml b/Build/testing-docker/docker-compose.yml
@@ -285,7 +285,7 @@ services:
           set -x
         fi
         php -v | grep '^PHP';
-        find . -name \\*.php ! -path "./.Build/\\*" -print0 | xargs -0 -n1 -P4 php -dxdebug.mode=off -l >/dev/null
+        find . -name \\*.php ! -path "./.Build/\\*" ! -path "./Resources/Private/CodeTemplates/\\*" -print0 | xargs -0 -n1 -P4 php -dxdebug.mode=off -l >/dev/null
       "
 
   phpstan:

diff --git a/Classes/Command/AcceptanceTestsCommand.php b/Classes/Command/AcceptanceTestsCommand.php
@@ -28,9 +28,20 @@
  */
 class AcceptanceTestsCommand extends AbstractCommand
 {
-    protected Filesystem $filesystem;
-    protected SymfonyStyle $io;
-    protected PackageInterface $package;
+    /**
+     * @var Filesystem $filesystem
+     */
+    protected $filesystem;
+
+    /**
+     * @var SymfonyStyle $io
+     */
+    protected $io;
+
+    /**
+     * @var PackageInterface $package
+     */
+    protected $package;
 
     protected function configure(): void
     {
@@ -117,7 +128,7 @@ protected function updateComposerFile(string $packagePath): bool
     {
         $composerFile = $packagePath . '/composer.json';
         $composerJson = file_get_contents($composerFile);
-        $composer = json_decode($composerJson, true, 512, JSON_THROW_ON_ERROR);
+        $composer = json_decode($composerJson, true);
         $namespace = rtrim($this->getNamespace(), '\\');
 
         // @todo: if a value already exists ask for permission to change it?!