Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add command 'make:testing:acceptance' #28

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ochorocho
Copy link
Contributor

@ochorocho ochorocho commented Apr 29, 2022

The command 'make:testing:acceptance' has been added
to create basic files and config to run
acceptance tests.

@ochorocho ochorocho force-pushed the feature/make-acceptance-tests branch 2 times, most recently from 596603b to 55e2ed8 Compare May 1, 2022 10:39
@ochorocho ochorocho marked this pull request as ready for review May 1, 2022 10:41
@ochorocho ochorocho force-pushed the feature/make-acceptance-tests branch from 55e2ed8 to 18b0993 Compare May 1, 2022 19:36
@ochorocho ochorocho marked this pull request as draft May 9, 2022 09:12
@ochorocho
Copy link
Contributor Author

On hold till #29 #30 are merged

@ochorocho ochorocho force-pushed the feature/make-acceptance-tests branch 2 times, most recently from 3314386 to 1d9a779 Compare May 26, 2022 22:26
Downloads runTests.sh and docker-compose.yml, modify for the selected extensions and put it into Build folder.
The command 'make:acceptance' has been added
to create basic files and config to run
acceptance tests.
The lint task not ignores files in
"Resources/Private/CodeTemplates/"
@ochorocho ochorocho force-pushed the feature/make-acceptance-tests branch from 1d9a779 to 3b651e4 Compare July 14, 2022 11:11
@ochorocho ochorocho force-pushed the feature/make-acceptance-tests branch from a89b3fb to 86abbe7 Compare July 14, 2022 11:24
@ochorocho ochorocho marked this pull request as ready for review July 14, 2022 11:49
@ochorocho ochorocho requested a review from o-ba July 14, 2022 11:49
@ochorocho ochorocho changed the title [FEATURE] Add command 'make:acceptance' [FEATURE] Add command 'make:testing:acceptance' Jul 14, 2022
@simonschaufi
Copy link
Contributor

both are merged now

'extra' => [
'typo3/cms' => [
'app-dir' => '.Build',
'web-dir' => '.Build/Web',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use public here as Web dates back to TYPO3 Flow times and should not be used in TYPO3 world.

paths:
tests: Acceptance
data: .
log: ../.Build/Web/typo3temp/var/tests/AcceptanceReports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use public

],
'xmlDatabaseFixtures' => [
'PACKAGE:typo3/testing-framework/Resources/Core/Acceptance/Fixtures/be_users.xml',
'PACKAGE:../Web/typo3conf/ext/{{EXTENSION_KEY}}/Tests/Acceptance/Fixtures/pages.xml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use public

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants