Pass async to tests, parallelizing them (#405)

b310-digital · Nov 10, 2024 · 5213ae2 · 5213ae2
1 parent ca9cf8e
commit 5213ae2
Show file tree

Hide file tree

Showing 31 changed files with 44 additions and 36 deletions.
diff --git a/.credo.exs b/.credo.exs
@@ -130,6 +130,7 @@
           {Credo.Check.Refactor.NegatedConditionsInUnless, []},
           {Credo.Check.Refactor.NegatedConditionsWithElse, []},
           {Credo.Check.Refactor.Nesting, []},
+          {Credo.Check.Refactor.PassAsyncInTestCases, []},
           {Credo.Check.Refactor.RedundantWithClauseResult, []},
           {Credo.Check.Refactor.RejectReject, []},
           {Credo.Check.Refactor.UnlessWithElse, []},
@@ -198,7 +199,6 @@
           {Credo.Check.Refactor.MapMap, []},
           {Credo.Check.Refactor.ModuleDependencies, []},
           {Credo.Check.Refactor.NegatedIsNil, []},
-          {Credo.Check.Refactor.PassAsyncInTestCases, []},
           {Credo.Check.Refactor.PipeChainStart, []},
           {Credo.Check.Refactor.RejectFilter, []},
           {Credo.Check.Refactor.VariableRebinding, []},

diff --git a/test/mindwendel/accounts_test.exs b/test/mindwendel/accounts_test.exs
@@ -1,5 +1,5 @@
 defmodule Mindwendel.AccountsTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Factory
   alias Mindwendel.Accounts
   alias Mindwendel.Accounts.User
@@ -125,13 +125,16 @@ defmodule Mindwendel.AccountsTest do
       )
 
       # we want to make sure that the database is not handling this with a foreign key restraint, but rather that it's handled in the app:
-      {_result, log} =
-        with_log(fn ->
+      log =
+        capture_log(fn ->
           Accounts.delete_inactive_users()
         end)
 
       assert Repo.exists?(from u in User, where: u.id == ^old_user.id)
-      assert log == ""
+      # we don't expect actual logs but due to async running other tests may emit logs at
+      # the same time and so we want to make sure here that no delete logs around the user
+      # are emitted
+      refute log =~ ~r/delet.*#{old_user.id}/i
     end
   end
 end
diff --git a/test/mindwendel/attachments_test.exs b/test/mindwendel/attachments_test.exs
@@ -1,5 +1,6 @@
 defmodule Mindwendel.AttachmentsTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
+
   alias Mindwendel.Factory
   alias Mindwendel.Attachments
 

diff --git a/test/mindwendel/brainstormings/create_brainstorming_test.exs b/test/mindwendel/brainstormings/create_brainstorming_test.exs
@@ -1,5 +1,5 @@
 defmodule Mindwendel.Brainstormings.CreateBrainstormingTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Brainstormings.BrainstormingModeratingUser
   alias Mindwendel.Accounts.BrainstormingUser
   alias Mindwendel.Factory

diff --git a/test/mindwendel/brainstormings_test.exs b/test/mindwendel/brainstormings_test.exs
@@ -1,6 +1,6 @@
 defmodule Mindwendel.BrainstormingsTest do
   alias Mindwendel.Brainstormings.IdeaIdeaLabel
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Brainstormings.BrainstormingModeratingUser
   alias Mindwendel.Factory
 

diff --git a/test/mindwendel/brainstormings_users_test.exs b/test/mindwendel/brainstormings_users_test.exs
@@ -1,5 +1,5 @@
 defmodule Mindwendel.AccountsMergeBrainstormingUserTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Factory
   alias Mindwendel.Accounts
   alias Mindwendel.Accounts.User

diff --git a/test/mindwendel/csv_formatter_test.exs b/test/mindwendel/csv_formatter_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelServices.CSVFormatter do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Factory
   alias Mindwendel.CSVFormatter
 

diff --git a/test/mindwendel/help_test.exs b/test/mindwendel/help_test.exs
@@ -1,5 +1,5 @@
 defmodule Mindwendel.HelpTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Factory
   alias Mindwendel.Help
 

diff --git a/test/mindwendel/idea_idea_label_test.exs b/test/mindwendel/idea_idea_label_test.exs
@@ -1,5 +1,5 @@
 defmodule Mindwendel.IdeaIdeaLabelTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Factory
 
   alias Mindwendel.Brainstormings.IdeaIdeaLabel

diff --git a/test/mindwendel/idea_labels_test.exs b/test/mindwendel/idea_labels_test.exs
@@ -1,5 +1,5 @@
 defmodule Mindwendel.IdeaLabelsTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Factory
 
   alias Mindwendel.Ideas

diff --git a/test/mindwendel/idea_test.exs b/test/mindwendel/idea_test.exs
@@ -1,5 +1,5 @@
 defmodule Mindwendel.IdeaTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Factory
 
   alias Mindwendel.Ideas

diff --git a/test/mindwendel/ideas_test.exs b/test/mindwendel/ideas_test.exs
@@ -1,5 +1,5 @@
 defmodule Mindwendel.IdeasTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Factory
 
   alias Mindwendel.Ideas

diff --git a/test/mindwendel/lanes_test.exs b/test/mindwendel/lanes_test.exs
@@ -1,5 +1,5 @@
 defmodule Mindwendel.LanesTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Lanes
   alias Mindwendel.Brainstormings.Lane
   import Mindwendel.BrainstormingsFixtures

diff --git a/test/mindwendel/likes_test.exs b/test/mindwendel/likes_test.exs
@@ -1,5 +1,5 @@
 defmodule Mindwendel.LikesTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Factory
   alias Mindwendel.Likes
 

diff --git a/test/mindwendel/services/storage_service_test.exs b/test/mindwendel/services/storage_service_test.exs
@@ -1,5 +1,6 @@
 defmodule Mindwendel.Brainstormings.StorageServiceTest do
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
+
   alias Mindwendel.Services.StorageService
 
   describe "#store_file" do

diff --git a/test/mindwendel/url_preview_test.exs b/test/mindwendel/url_preview_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelServices.UrlPreviewTest do
-  use ExUnit.Case
+  use ExUnit.Case, async: true
   alias Mindwendel.UrlPreview
 
   setup do

diff --git a/test/mindwendel_web/channels/brainstorming_channel_test.exs b/test/mindwendel_web/channels/brainstorming_channel_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelWeb.BrainstormingChannelTest do
-  use MindwendelWeb.ChannelCase
+  use MindwendelWeb.ChannelCase, async: true
 
   alias Mindwendel.Factory
   alias Mindwendel.Brainstormings

diff --git a/test/mindwendel_web/controllers/brainstorming_controller_test.exs b/test/mindwendel_web/controllers/brainstorming_controller_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelWeb.BrainstormingControllerTest do
-  use MindwendelWeb.ConnCase
+  use MindwendelWeb.ConnCase, async: true
 
   import Ecto.Query
 

diff --git a/test/mindwendel_web/controllers/file_controller_test.exs b/test/mindwendel_web/controllers/file_controller_test.exs
@@ -1,5 +1,6 @@
 defmodule MindwendelWeb.FileControllerTest do
-  use MindwendelWeb.ConnCase
+  use MindwendelWeb.ConnCase, async: true
+
   alias Mindwendel.Services.Vault
   alias Mindwendel.Factory
 

diff --git a/test/mindwendel_web/controllers/static_page_controller_test.exs b/test/mindwendel_web/controllers/static_page_controller_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelWeb.StaticPageControllerTest do
-  use MindwendelWeb.ConnCase
+  use MindwendelWeb.ConnCase, async: true
   alias Mindwendel.Factory
   alias Mindwendel.Repo
 

diff --git a/test/mindwendel_web/live/admin/brainstorming_live/edit_test.exs b/test/mindwendel_web/live/admin/brainstorming_live/edit_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelWeb.Admin.BrainstormingLive.EditTest do
-  use MindwendelWeb.ConnCase
+  use MindwendelWeb.ConnCase, async: true
   import Phoenix.LiveViewTest
 
   alias Mindwendel.Factory

diff --git a/test/mindwendel_web/live/brainstorming_live/show_idea_delete_test.exs b/test/mindwendel_web/live/brainstorming_live/show_idea_delete_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelWeb.BrainstormingLive.ShowIdeaDeleteTest do
-  use MindwendelWeb.ConnCase
+  use MindwendelWeb.ConnCase, async: true
   import Phoenix.LiveViewTest
   alias Mindwendel.Brainstormings
 

diff --git a/test/mindwendel_web/live/brainstorming_live/show_idea_edit_test.exs b/test/mindwendel_web/live/brainstorming_live/show_idea_edit_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelWeb.BrainstormingLive.ShowIdeaEditTest do
-  use MindwendelWeb.ConnCase
+  use MindwendelWeb.ConnCase, async: true
   import Phoenix.LiveViewTest
   alias Mindwendel.Brainstormings
   alias Mindwendel.Accounts.User

diff --git a/test/mindwendel_web/live/brainstorming_live/show_sort_by_label_test.exs b/test/mindwendel_web/live/brainstorming_live/show_sort_by_label_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelWeb.BrainstormingLive.ShowSortByLabelTest do
-  use MindwendelWeb.ConnCase
+  use MindwendelWeb.ConnCase, async: true
   import Phoenix.LiveViewTest
   alias Mindwendel.Brainstormings
 

diff --git a/test/mindwendel_web/live/brainstorming_live_test.exs b/test/mindwendel_web/live/brainstorming_live_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelWeb.BrainstormingLiveTest do
-  use MindwendelWeb.ConnCase
+  use MindwendelWeb.ConnCase, async: true
   import Phoenix.LiveViewTest
 
   alias Mindwendel.Brainstormings

diff --git a/test/mindwendel_web/live/label_live/captions_test.exs b/test/mindwendel_web/live/label_live/captions_test.exs
@@ -1,11 +1,13 @@
 defmodule MindwendelWeb.LabelLive.CaptionsTest do
-  alias MindwendelWeb.LabelLive.CaptionsComponent
-  alias Mindwendel.Brainstormings
-  use MindwendelWeb.ConnCase
+  use MindwendelWeb.ConnCase, async: true
+
   import Phoenix.LiveViewTest
 
+  alias Mindwendel.Brainstormings
   alias Mindwendel.Factory
 
+  alias MindwendelWeb.LabelLive.CaptionsComponent
+
   setup do
     %{brainstorming: Factory.insert!(:brainstorming), user: Factory.insert!(:user)}
   end

diff --git a/test/mindwendel_web/live/live_helpers_test.exs b/test/mindwendel_web/live/live_helpers_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelWeb.LiveHelpersTest do
-  use MindwendelWeb.ConnCase
+  use MindwendelWeb.ConnCase, async: true
   import Phoenix.LiveViewTest
 
   alias Mindwendel.Factory

diff --git a/test/mindwendel_web/live/response_header_content_security_policy_test.exs b/test/mindwendel_web/live/response_header_content_security_policy_test.exs
@@ -1,5 +1,5 @@
 defmodule MindwendelWeb.ResponseHeaderContentSecurityPolicyTest do
-  use MindwendelWeb.ConnCase
+  use MindwendelWeb.ConnCase, async: true
 
   alias Mindwendel.Factory
 

diff --git a/test/repo/data_migrations/migrate_add_lanes_to_brainstormings_test.exs b/test/repo/data_migrations/migrate_add_lanes_to_brainstormings_test.exs
@@ -1,7 +1,7 @@
 defmodule Mindwendel.Repo.DataMigrations.MigrateAddLanesToBrainstormingsTest do
   Code.require_file("./priv/repo/data_migrations/migrate_add_lanes_to_brainstormings.exs")
 
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Factory
   alias Mindwendel.Lanes
   alias Mindwendel.Repo.DataMigrations.MigrateAddLanesToBrainstormings

diff --git a/test/repo/data_migrations/migrate_idea_labels_test.exs b/test/repo/data_migrations/migrate_idea_labels_test.exs
@@ -1,7 +1,7 @@
 defmodule Mindwendel.Repo.DataMigrations.MigrateIdealLabelsTest do
   Code.require_file("./priv/repo/data_migrations/migrate_idea_labels.exs")
 
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
   alias Mindwendel.Factory
   alias Mindwendel.Repo
   alias Mindwendel.Brainstormings.Brainstorming

diff --git a/test/repo/data_migrations/migrate_idea_labels_to_idea_idea_labels_test.exs b/test/repo/data_migrations/migrate_idea_labels_to_idea_idea_labels_test.exs
@@ -1,7 +1,7 @@
 defmodule Mindwendel.Repo.DataMigrations.MigrateIdeaLabelsToIdeaIdeaLabelsTest do
   Code.require_file("./priv/repo/data_migrations/migrate_idea_labels_to_idea_idea_labels.exs")
 
-  use Mindwendel.DataCase
+  use Mindwendel.DataCase, async: true
 
   alias Mindwendel.Factory
   alias Mindwendel.Repo