Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/adapt to yosemite #45

Closed
wants to merge 30 commits into from

Conversation

zenangst
Copy link

I've added a new tab style that conforms with the new look in Yosemite.

I was wondering what you guys think of it so far?

On my todo list so far:

  • Change the way the close button looks and behaves
  • Change tab bar height
  • Change the "New Tab" icon on the right side
  • Change font color depending on tab state - zenangst@67fb6e6

screen shot 2014-09-14 at 11 06 35

Makes more sense to truncate on head because of Cocoa name-spacing
prefixes
Making it feel more like Xcode than Terminal (I don’t know how I feel
about this)
Match Xcode 6
Remove C preprocessor
@lucascaton
Copy link

That looks amazing dude, nice job! Congrats!

@tomekw
Copy link

tomekw commented Oct 18, 2014

No idea where to raise this issue but entering the fullscreen doesn't work on Yosemite (/cc @b4winckler)

Top left corner:

http://cl.ly/image/292113231m3L

Bottom left corner:

http://cl.ly/image/120P0M1R122Q

@maxcountryman
Copy link

@tomekw I'm having the same problem.

@benoitc
Copy link

benoitc commented Oct 27, 2014

@tomekw @maxcountryman I applied this patch in my repo [1] from the google code tracker [2] as a workaround. It seems to fix most case even if resizing is not that good.

[1] benoitc@9f77ac3
[2] https://code.google.com/p/macvim/issues/detail?id=514&start=100

@eric-wood
Copy link

This is fantastic, really looking forward to this making it upstream! 👍 👍 👍

@RobertsChou
Copy link

Thank u , good job

@krid78
Copy link

krid78 commented Oct 30, 2014

I compiled and testes the version (zenangst/macvim). The issue with missing top lines when only one tab is open at full screen mode is still there.

regards

@jordwalke
Copy link

👍

@vestimir
Copy link

Looks great. 👍

offtopic: @krid78 @benoitc @tomekw About the blank lines there's a fix in progress here - #48

@mikekreeki
Copy link

👍

1 similar comment
@eirnym
Copy link

eirnym commented Jan 18, 2015

👍

@luishdez
Copy link

Awesome work!

I will add these extras to the tasks

[ ] Use hover native scrolls ( invisible ones )
[ ] Dark mode for yosemite

@UrsaDK
Copy link

UrsaDK commented Jan 28, 2015

👍

@zenangst
Copy link
Author

Hey folks, thanks for your support and enthusiasm. Kinda swamped at work right now but this is on my todo-list... and I would love to finish pully.

@vestimir
Copy link

@zenangst what do you mean by

Change the way the close button looks and behaves

PS: Great job so far! 🎯

@christianparpart
Copy link

hey guys. is there an update on this so far? or got it suspended?

@simono
Copy link

simono commented Mar 13, 2015

I don't think this repository is active anymore. #44 (comment)

@jean-io
Copy link

jean-io commented Oct 6, 2015

Hi,

This repo is no longer active, however this one is: https://github.com/macvim-dev/macvim

Any chance you could update it?

@mikekreeki
Copy link

Would be very cool 👍

@jordwalke
Copy link

This would be really awesome to have. Any chance you could submit the pull request to the new official repo at https://github.com/macvim-dev/macvim ? That repo is fairly active now and I'm hoping there will be some people excited to take a closer look at your PR.

splhack added a commit to macvim-dev/macvim that referenced this pull request Dec 28, 2015
@splhack
Copy link
Contributor

splhack commented Dec 28, 2015

I've revised this pull request in macvim-dev/macvim#193, now you can improve and send pull requests for feature/yosemite-tab-style branch of https://github.com/macvim-dev/macvim.

splhack added a commit to macvim-dev/macvim that referenced this pull request Jan 15, 2016
splhack added a commit to macvim-dev/macvim that referenced this pull request Jan 15, 2016
splhack added a commit to macvim-dev/macvim that referenced this pull request Jan 15, 2016
Binary targets OS X 10.8(Mountain Lion), 10.9(Mavericks), 10.10(Yosemite), and 10.11(El Capitan)

- Vim patch 7.4.1090
- Fix renderer defaults settings, Core Text Renderer should be the default
- Yosemite style Tab bar based on b4winckler/macvim#45

Script interfaces have compatibility with these versions

- Lua 5.2
- Perl 5.16
- Python2 2.7
- Python3 3.5
- Ruby 2.0
@zenangst zenangst closed this Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.