Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex support #16

Merged
merged 9 commits into from
Jun 28, 2024
Merged

Regex support #16

merged 9 commits into from
Jun 28, 2024

Conversation

Tamyer
Copy link

@Tamyer Tamyer commented Jun 26, 2024

Changes:

  • Add assertion message with regex expressions
  • Add regex assertion tests to LogRecordTest suite

@Tamyer Tamyer requested a review from jvanecek June 26, 2024 15:45
@Tamyer Tamyer self-assigned this Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.19%. Comparing base (37deb5b) to head (20149c8).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release-candidate      #16      +/-   ##
=====================================================
+ Coverage              96.85%   98.19%   +1.33%     
=====================================================
  Files                     11       11              
  Lines                    414      444      +30     
=====================================================
+ Hits                     401      436      +35     
+ Misses                    13        8       -5     
Flag Coverage Δ
unit 98.19% <100.00%> (+1.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mtabacman
mtabacman previously approved these changes Jun 26, 2024
source/Bell-SUnit/LoggingAsserter.class.st Outdated Show resolved Hide resolved
source/Bell-Logging-Tests/LogRecordTest.class.st Outdated Show resolved Hide resolved
@gcotelli gcotelli merged commit d03b538 into release-candidate Jun 28, 2024
46 checks passed
@gcotelli gcotelli deleted the regex-support branch June 28, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants