-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 10-18.md #120
Open
nicolo-ribaudo
wants to merge
1
commit into
master
Choose a base branch
from
nicolo-ribaudo-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create 10-18.md #120
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Oct 18 notes | ||
|
||
Attendees: @nicolo-ribaudo @JLHwung @liuxingbaoyu | ||
|
||
- 7.20.0 - Small, but do not wait too long because people are excited about TS `expr satisfies X` | ||
- https://github.com/babel/babel/pull/14966 not included in mileston because big and might need some discussion, no need to block the release | ||
|
||
- Babel 8 | ||
- We potentially ready to publish a pre-release, but would like to first include all the big missing breaking changes | ||
- AST changes: ImportExpression, https://github.com/babel/babel/issues/9545 (typescript-eslint/typescript-estree: https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/typescript-estree) | ||
- ESM only? | ||
- A bit hesitant about it, but probably fine? | ||
- webpack, rollup, @babel/cli already use Babel asynchronously | ||
- @babel/register and @babel/eslint-parser work with the ESM version | ||
- Jest might have problems? | ||
- CJS for some packages that are used outside of Babel, like `@babel/parser` and `@babel/code-frame` | ||
- If moving stable plugin to @babel/core, we shouldn't publish version 8 of them (e.g. no `@babel/[email protected]`) | ||
- For maintainance, use 2 branches. | ||
- Only security fixes for Babel 7, and maybe normal fixes if companies sponsor us for that? | ||
- What about security fixes that require upgradig a dependency that drops an old Node.js version? | ||
- We can release `7.20.3-nodejs12` to signal that the fix requires Node.js 12 | ||
- It would be nice if you can specify a dependency as `"3 || 4"` and the package manager downloads the highest compatible with the current Node.js version (npm has it! https://github.com/npm/rfcs/blob/main/implemented/0023-acceptDependencies.md) (Check if yarn / pnpm are going to support this) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely not fine :-) there's no advantage to shipping ESM-only, and tons of downsides. just stick to CJS.