Add function rettype for default values #625
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| format_type_be(type_id)), | ||
| errhint("You will need to rewrite or cast the expression."))); | ||
|
|
||
| if (handle_type_and_collation_hook) |
There was a problem hiding this comment.
Would you mind explain the user case why we need to add this line and follow up with test cases ? It can help us to understand the priority and necessary to merge this change into main branch.
There was a problem hiding this comment.
I explain the reason why we need this fix in issue babelfish-for-postgresql/babelfish_extensions#4069
I also would like add test scenarios but the JDBC tests are in babelfish repository. How can I add my test cases here?
There was a problem hiding this comment.
Here I created the failing test case in babelfish_repository
babelfish-for-postgresql/babelfish_extensions#4123
This was referenced Sep 24, 2025
bilalkah
force-pushed
the
fix_funcrettype_for_cook_default
branch
from
bc7cadf to
09a4bf9
Compare
Signed-off-by: Bilal Kahraman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the cook default function behavior by setting function return type.
Issues Resolved
babelfish-for-postgresql/babelfish_extensions#4069
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.