Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable gosec #13

Merged
merged 2 commits into from
Oct 4, 2024
+14 −4
Merged

chore: Enable gosec #13

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40edc7f
chore: Enable gosec
vitsalis Oct 4, 2024
d98ddf5
Update docker pipeline
vitsalis Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
@@ -7,11 +7,14 @@ on:

jobs:
lint_test:
uses: babylonlabs-io/.github/.github/workflows/reusable_go_lint_test.yml@v0.1.0
uses: babylonlabs-io/.github/.github/workflows/reusable_go_lint_test.yml@v0.6.0
with:
run-unit-tests: true
run-integration-tests: true
run-lint: true
run-build: true
run-gosec: true
gosec-args: "-exclude-generated ./..."

docker_pipeline:
uses: babylonlabs-io/.github/.github/workflows/[email protected]
9 changes: 7 additions & 2 deletions .github/workflows/publish.yml
View file
Original file line number Diff line number Diff line change
@@ -9,15 +9,20 @@ on:

jobs:
lint_test:
uses: babylonlabs-io/.github/.github/workflows/reusable_go_lint_test.yml@v0.1.0
uses: babylonlabs-io/.github/.github/workflows/reusable_go_lint_test.yml@v0.6.0
with:
run-unit-tests: true
run-integration-tests: true
run-lint: true
run-build: true
run-gosec: true
gosec-args: "-exclude-generated ./..."

docker_pipeline:
needs: ["lint_test"]
uses: babylonlabs-io/.github/.github/workflows/reusable_docker_pipeline.yml@v0.1.0
uses: babylonlabs-io/.github/.github/workflows/reusable_docker_pipeline.yml@v0.6.0
secrets: inherit
with:
publish: true
dockerfile: ./Dockerfile
repoName: covenant-signer

Unchanged files with check annotations Beta

View file
Dockerfile
FROM golang:1.22.3-alpine as builder

Check warning on line 1 in Dockerfile

GitHub Actions / docker_pipeline / docker_build

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
# Version to build. Default is the Git HEAD.
ARG VERSION="HEAD"