feat: BBN/BTC env #565
Merged
feat: BBN/BTC env #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totraev
approved these changes
Dec 25, 2024
jeremy-babylonlabs
approved these changes
Dec 25, 2024
|
nice work! |
|
@jrwbabylonlab are you happy with the change? If yes and no requests - please merge it, or ping me so I will merge it |
| chainId: bbnTestnet.chainId, | ||
| rpc: bbnTestnet.rpc, | ||
| chainData: bbnTestnet, | ||
| }; |
There was a problem hiding this comment.
nit: probably best to not include the mainnet for now, just to avoid some confusion
There was a problem hiding this comment.
A seperate question on this. I wonder how would private mainnet config should look like. It connects to mainnet btc, but still a testing env 🤔
jrwbabylonlab
approved these changes
Dec 25, 2024
|
I will merge ur PR for now |
| @@ -0,0 +1,58 @@ | |||
| export const BBN_DEVNET_RPC_URL = "https://babylon-testnet-rpc.nodes.guru"; | |||
| export const BBN_DEVNET_LCD_URL = "https://babylon-testnet-api.nodes.guru"; | |||
There was a problem hiding this comment.
@gbarkhatov just notice a typo here. BBN_DEVNET_LCD_URL has devnet in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bbn-wallet-connectCloses #563