Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with fee UI react rendering loop #66

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

jrwbabylonlab
Copy link
Collaborator

No description provided.

@jrwbabylonlab jrwbabylonlab changed the base branch from dev to main August 12, 2024 11:38
@jrwbabylonlab jrwbabylonlab force-pushed the fix-fee-infinite-react-loop-2 branch from 68f9f03 to 27366d6 Compare August 12, 2024 11:44
Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's have some documentation behind the decision.

src/utils/isStakingSignReady.ts Show resolved Hide resolved
Copy link
Contributor

@jeremy-babylonlabs jeremy-babylonlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested on chrome

src/utils/isStakingSignReady.ts Outdated Show resolved Hide resolved
@jrwbabylonlab jrwbabylonlab force-pushed the fix-fee-infinite-react-loop-2 branch from 27366d6 to c4538f1 Compare August 13, 2024 01:38
@jrwbabylonlab jrwbabylonlab force-pushed the fix-fee-infinite-react-loop-2 branch from c4538f1 to 6372afd Compare August 13, 2024 01:40
@jrwbabylonlab jrwbabylonlab merged commit 3b571bb into main Aug 13, 2024
1 check passed
@jrwbabylonlab jrwbabylonlab deleted the fix-fee-infinite-react-loop-2 branch August 13, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants