Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12: Upgrade to latest version of PHPCS. Matching Drupal 8.3.12 version. #18

Open
wants to merge 1 commit into
base: 1.x-1.x
Choose a base branch
from

Conversation

quicksketch
Copy link
Member

Fixes #12.

This is an alternative to #14, instead of updating the current rules to work with the new version of PHPCS, this copies the Drupal 8.3.12 version of Coder Module's rules, which better utilize Squidz's libraries rather than recreating our own rules for CSS files and most whitespace handling.

@laryn
Copy link
Member

laryn commented Jan 13, 2023

@quicksketch
I'm testing this PR and I ran into an issue as described here (and fixed in the minimal patch attached to this comment):

https://www.drupal.org/project/coder/issues/3204177#comment-14705137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to a newer version of PHP_CodeSniffer
2 participants