Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep): update k8s-client for ocm, k8s-scaffolder, topology, tekton plugins #2843

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Feb 7, 2025

Hey, I just made a Pull Request!

update @kubernetes/client-node to version 1.0.0-rc7 for:

  • ocm
  • scaffolder-backend-module-kubernetes
  • topology
  • tekton

Additional details

Newer k8s client has changed error handling. For now error body could be or string or binary:

https://github.com/kubernetes-client/javascript/blob/1.0.0/src/object.ts#L666

Erlier it could be with 'object' body:

https://github.com/kubernetes-client/javascript/blob/0.22.1/src/object.ts#L800

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Feb 7, 2025

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage-community/plugin-ocm-backend
  • @backstage-community/plugin-ocm
  • @backstage-community/plugin-scaffolder-backend-module-kubernetes
  • @backstage-community/plugin-tekton
  • @backstage-community/plugin-topology

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-ocm-backend workspaces/ocm/plugins/ocm-backend none v5.3.0
@backstage-community/plugin-ocm workspaces/ocm/plugins/ocm none v5.3.1
@backstage-community/plugin-scaffolder-backend-module-kubernetes workspaces/scaffolder-backend-module-kubernetes/plugins/kubernetes-actions none v2.4.0
@backstage-community/plugin-tekton workspaces/tekton/plugins/tekton none v3.18.0
@backstage-community/plugin-topology workspaces/topology/plugins/topology none v1.31.0

@AndrienkoAleksandr AndrienkoAleksandr force-pushed the update-kubernetes-client-node branch from 82a98bd to a8df7d0 Compare February 10, 2025 04:19
@AndrienkoAleksandr AndrienkoAleksandr changed the title chore(dep): update k8s-client for ocm and k8s scaffolder plugins chore(dep): update k8s-client for ocm, k8s-scaffolder, topology, tekton plugins Feb 10, 2025
@AndrienkoAleksandr AndrienkoAleksandr marked this pull request as ready for review February 10, 2025 05:58
Signed-off-by: Oleksandr Andriienko <[email protected]>
Copy link
Contributor

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything worked for me expect for the OCM page. I kept getting the following when navigating to the page. I was able to fix the problem by removing some of the duplicated dependencies.

Screenshot from 2025-02-10 11-04-33

/cc @christoph-jerolimov

@04kash 04kash self-requested a review February 11, 2025 18:12
Copy link
Contributor

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@invincibleJai
Copy link
Contributor

Tested and everything worked for me expect for the OCM page. I kept getting the following when navigating to the page. I was able to fix the problem by removing some of the duplicated dependencies.

Screenshot from 2025-02-10 11-04-33

/cc @christoph-jerolimov

I have created a PR #2877 to get this fixed and added workspace as well to make it easier to test

@AndrienkoAleksandr AndrienkoAleksandr merged commit f7581c2 into backstage:main Feb 12, 2025
21 checks passed
Copy link
Member

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrienkoAleksandr just noticed that this PR doesn't have any changesets. Is that required?

gaelgoth pushed a commit to gaelgoth/community-plugins that referenced this pull request Feb 12, 2025
…on plugins (backstage#2843)

* chore(dep): update k8s-client for ocm and k8s scaffolder plugins

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): fix unit tests

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): update yarn.lock files

Signed-off-by: Oleksandr Andriienko <[email protected]>

* fix(rbac): update topology and tekton plugins

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): work on error handling

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): remove deps that break application startup

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): update react libs instead of removing

Signed-off-by: Oleksandr Andriienko <[email protected]>

---------

Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: gaelgoth <[email protected]>
gaelgoth pushed a commit to gaelgoth/community-plugins that referenced this pull request Feb 12, 2025
…on plugins (backstage#2843)

* chore(dep): update k8s-client for ocm and k8s scaffolder plugins

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): fix unit tests

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): update yarn.lock files

Signed-off-by: Oleksandr Andriienko <[email protected]>

* fix(rbac): update topology and tekton plugins

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): work on error handling

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): remove deps that break application startup

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): update react libs instead of removing

Signed-off-by: Oleksandr Andriienko <[email protected]>

---------

Signed-off-by: Oleksandr Andriienko <[email protected]>
gaelgoth pushed a commit to gaelgoth/community-plugins that referenced this pull request Feb 12, 2025
…on plugins (backstage#2843)

* chore(dep): update k8s-client for ocm and k8s scaffolder plugins

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): fix unit tests

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): update yarn.lock files

Signed-off-by: Oleksandr Andriienko <[email protected]>

* fix(rbac): update topology and tekton plugins

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): work on error handling

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): remove deps that break application startup

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): update react libs instead of removing

Signed-off-by: Oleksandr Andriienko <[email protected]>

---------

Signed-off-by: Oleksandr Andriienko <[email protected]>
AndrienkoAleksandr added a commit to AndrienkoAleksandr/community-plugins that referenced this pull request Feb 13, 2025
Add missed chagnesets for:
- ocm
- topolody
- tekton
- scaffolder-backend-module-kubernetes

Signed-off-by: Oleksandr Andriienko <[email protected]>
AndrienkoAleksandr added a commit to AndrienkoAleksandr/community-plugins that referenced this pull request Feb 13, 2025
Add missed chagnesets for:
- ocm
- topolody
- tekton
- scaffolder-backend-module-kubernetes

Signed-off-by: Oleksandr Andriienko <[email protected]>
AndrienkoAleksandr added a commit to AndrienkoAleksandr/community-plugins that referenced this pull request Feb 17, 2025
Add missed chagnesets for:
- ocm
- topolody
- tekton
- scaffolder-backend-module-kubernetes

Signed-off-by: Oleksandr Andriienko <[email protected]>
AndrienkoAleksandr added a commit that referenced this pull request Feb 17, 2025
* fix(changeset): add missed changesets after pr: #2843
Add missed chagnesets for:
- ocm
- scaffolder-backend-module-kubernetes

Signed-off-by: Oleksandr Andriienko <[email protected]>
CryptoRodeo pushed a commit to CryptoRodeo/community-plugins that referenced this pull request Feb 18, 2025
* fix(changeset): add missed changesets after pr: backstage#2843
Add missed chagnesets for:
- ocm
- scaffolder-backend-module-kubernetes

Signed-off-by: Oleksandr Andriienko <[email protected]>
Zarthus pushed a commit to Zarthus/community-plugins that referenced this pull request Feb 19, 2025
…on plugins (backstage#2843)

* chore(dep): update k8s-client for ocm and k8s scaffolder plugins

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): fix unit tests

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): update yarn.lock files

Signed-off-by: Oleksandr Andriienko <[email protected]>

* fix(rbac): update topology and tekton plugins

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): work on error handling

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): remove deps that break application startup

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): update react libs instead of removing

Signed-off-by: Oleksandr Andriienko <[email protected]>

---------

Signed-off-by: Oleksandr Andriienko <[email protected]>
Zarthus pushed a commit to Zarthus/community-plugins that referenced this pull request Feb 19, 2025
* fix(changeset): add missed changesets after pr: backstage#2843
Add missed chagnesets for:
- ocm
- scaffolder-backend-module-kubernetes

Signed-off-by: Oleksandr Andriienko <[email protected]>
harmenbrinkmanTRIMM pushed a commit to harmenbrinkmanTRIMM/community-plugins that referenced this pull request Feb 19, 2025
…on plugins (backstage#2843)

* chore(dep): update k8s-client for ocm and k8s scaffolder plugins

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): fix unit tests

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): update yarn.lock files

Signed-off-by: Oleksandr Andriienko <[email protected]>

* fix(rbac): update topology and tekton plugins

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): work on error handling

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): remove deps that break application startup

Signed-off-by: Oleksandr Andriienko <[email protected]>

* chore(dep): update react libs instead of removing

Signed-off-by: Oleksandr Andriienko <[email protected]>

---------

Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Harmen Brinkman <[email protected]>
harmenbrinkmanTRIMM pushed a commit to harmenbrinkmanTRIMM/community-plugins that referenced this pull request Feb 19, 2025
* fix(changeset): add missed changesets after pr: backstage#2843
Add missed chagnesets for:
- ocm
- scaffolder-backend-module-kubernetes

Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Harmen Brinkman <[email protected]>
sednus pushed a commit to sednus/community-plugins that referenced this pull request Feb 20, 2025
* fix(changeset): add missed changesets after pr: backstage#2843
Add missed chagnesets for:
- ocm
- scaffolder-backend-module-kubernetes

Signed-off-by: Oleksandr Andriienko <[email protected]>
sednus pushed a commit to sednus/community-plugins that referenced this pull request Feb 20, 2025
* fix(changeset): add missed changesets after pr: backstage#2843
Add missed chagnesets for:
- ocm
- scaffolder-backend-module-kubernetes

Signed-off-by: Oleksandr Andriienko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants