-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dep): update k8s-client for ocm, k8s-scaffolder, topology, tekton plugins #2843
chore(dep): update k8s-client for ocm, k8s-scaffolder, topology, tekton plugins #2843
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
82a98bd
to
a8df7d0
Compare
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and everything worked for me expect for the OCM page. I kept getting the following when navigating to the page. I was able to fix the problem by removing some of the duplicated dependencies.
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I have created a PR #2877 to get this fixed and added workspace as well to make it easier to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrienkoAleksandr just noticed that this PR doesn't have any changesets. Is that required?
…on plugins (backstage#2843) * chore(dep): update k8s-client for ocm and k8s scaffolder plugins Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): fix unit tests Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): update yarn.lock files Signed-off-by: Oleksandr Andriienko <[email protected]> * fix(rbac): update topology and tekton plugins Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): work on error handling Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): remove deps that break application startup Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): update react libs instead of removing Signed-off-by: Oleksandr Andriienko <[email protected]> --------- Signed-off-by: Oleksandr Andriienko <[email protected]> Signed-off-by: gaelgoth <[email protected]>
…on plugins (backstage#2843) * chore(dep): update k8s-client for ocm and k8s scaffolder plugins Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): fix unit tests Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): update yarn.lock files Signed-off-by: Oleksandr Andriienko <[email protected]> * fix(rbac): update topology and tekton plugins Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): work on error handling Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): remove deps that break application startup Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): update react libs instead of removing Signed-off-by: Oleksandr Andriienko <[email protected]> --------- Signed-off-by: Oleksandr Andriienko <[email protected]>
…on plugins (backstage#2843) * chore(dep): update k8s-client for ocm and k8s scaffolder plugins Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): fix unit tests Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): update yarn.lock files Signed-off-by: Oleksandr Andriienko <[email protected]> * fix(rbac): update topology and tekton plugins Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): work on error handling Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): remove deps that break application startup Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): update react libs instead of removing Signed-off-by: Oleksandr Andriienko <[email protected]> --------- Signed-off-by: Oleksandr Andriienko <[email protected]>
Add missed chagnesets for: - ocm - topolody - tekton - scaffolder-backend-module-kubernetes Signed-off-by: Oleksandr Andriienko <[email protected]>
Add missed chagnesets for: - ocm - topolody - tekton - scaffolder-backend-module-kubernetes Signed-off-by: Oleksandr Andriienko <[email protected]>
Add missed chagnesets for: - ocm - topolody - tekton - scaffolder-backend-module-kubernetes Signed-off-by: Oleksandr Andriienko <[email protected]>
* fix(changeset): add missed changesets after pr: #2843 Add missed chagnesets for: - ocm - scaffolder-backend-module-kubernetes Signed-off-by: Oleksandr Andriienko <[email protected]>
* fix(changeset): add missed changesets after pr: backstage#2843 Add missed chagnesets for: - ocm - scaffolder-backend-module-kubernetes Signed-off-by: Oleksandr Andriienko <[email protected]>
…on plugins (backstage#2843) * chore(dep): update k8s-client for ocm and k8s scaffolder plugins Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): fix unit tests Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): update yarn.lock files Signed-off-by: Oleksandr Andriienko <[email protected]> * fix(rbac): update topology and tekton plugins Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): work on error handling Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): remove deps that break application startup Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): update react libs instead of removing Signed-off-by: Oleksandr Andriienko <[email protected]> --------- Signed-off-by: Oleksandr Andriienko <[email protected]>
* fix(changeset): add missed changesets after pr: backstage#2843 Add missed chagnesets for: - ocm - scaffolder-backend-module-kubernetes Signed-off-by: Oleksandr Andriienko <[email protected]>
…on plugins (backstage#2843) * chore(dep): update k8s-client for ocm and k8s scaffolder plugins Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): fix unit tests Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): update yarn.lock files Signed-off-by: Oleksandr Andriienko <[email protected]> * fix(rbac): update topology and tekton plugins Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): work on error handling Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): remove deps that break application startup Signed-off-by: Oleksandr Andriienko <[email protected]> * chore(dep): update react libs instead of removing Signed-off-by: Oleksandr Andriienko <[email protected]> --------- Signed-off-by: Oleksandr Andriienko <[email protected]> Signed-off-by: Harmen Brinkman <[email protected]>
* fix(changeset): add missed changesets after pr: backstage#2843 Add missed chagnesets for: - ocm - scaffolder-backend-module-kubernetes Signed-off-by: Oleksandr Andriienko <[email protected]> Signed-off-by: Harmen Brinkman <[email protected]>
* fix(changeset): add missed changesets after pr: backstage#2843 Add missed chagnesets for: - ocm - scaffolder-backend-module-kubernetes Signed-off-by: Oleksandr Andriienko <[email protected]>
* fix(changeset): add missed changesets after pr: backstage#2843 Add missed chagnesets for: - ocm - scaffolder-backend-module-kubernetes Signed-off-by: Oleksandr Andriienko <[email protected]>
Hey, I just made a Pull Request!
update @kubernetes/client-node to version 1.0.0-rc7 for:
Additional details
Newer k8s client has changed error handling. For now error body could be or string or binary:
https://github.com/kubernetes-client/javascript/blob/1.0.0/src/object.ts#L666
Erlier it could be with 'object' body:
https://github.com/kubernetes-client/javascript/blob/0.22.1/src/object.ts#L800
✔️ Checklist
Signed-off-by
line in the message. (more info)