Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flushAuctions function #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brianmcmichael
Copy link

Adds a flushAuctions() function that can be called by anyone.

When called, it iterates through the set and clears out any of the auctions that have been outbid. This should be relatively inexpensive for the sender due to the gas refund of clearing this state and it also reduces the cost of all of the functions that call _getActiveAuctionVatDaiTotal()

This should be considered as a gas saving device to reduce the likelihood of set size lockup identified in #46

Auctions that have been won will still have to be dealt individually. This function does not finalize auctions past their end time due to the higher gas cost involved with that process.

This PR just adds the function. I would imagine that it could be even more effective if it was converted to public and called whenever someone enlists or defects, but I'd need to explore the consequences of that a little further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant