Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
flushAuctions()
function that can be called by anyone.When called, it iterates through the set and clears out any of the auctions that have been outbid. This should be relatively inexpensive for the sender due to the gas refund of clearing this state and it also reduces the cost of all of the functions that call
_getActiveAuctionVatDaiTotal()
This should be considered as a gas saving device to reduce the likelihood of set size lockup identified in #46
Auctions that have been won will still have to be
deal
t individually. This function does not finalize auctions past their end time due to the higher gas cost involved with that process.This PR just adds the function. I would imagine that it could be even more effective if it was converted to
public
and called whenever someoneenlist
s ordefect
s, but I'd need to explore the consequences of that a little further.