-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restricted Textbox Component #15
base: master
Are you sure you want to change the base?
Conversation
I think this should be 3 components 1 controller with validation (needs more char - limit char) controller onChange then to pass the val to the textarea and pass the count / max / has-error to the label that way you can test the textarea and the label separately |
Having a bit of difficulty seeing this, could you give a usage example for those? e.g. |
It is more moving renderRemaining to a new component and passing it the bits it needs |
working on jsbin |
Ah okay... yeah that's a somewhat lazy pattern I've gotten into... I'll try not to do that. |
http://jsbin.com/xewayoti/1/edit updated |
updated jsbin |
* Add `<MainHeader/>` with logo and navigation * Add `<MainNav/>` with nav items. Also tracks current page * Update folder structure for /client and /test * Add `npm run build`
Awesome! I committed your changes (there was a syntax error in the jsbin for some reason, so just fixed that). |
Thinking on this more - do we need this to have a min? as it would reduce complexity of the component and still be size limited. I was just wondering if it would be easier to comprehend as a reader new to the concepts. |
So... this component is weird. We probably at least want to improve the styles.
Here's an example of it in jsbin.