[release-0.12] Merge pull request #1519 from tesshuflower/resourcenamelimit_63chars #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3chars Resourcenamelimit 63chars (cherry picked from commit 9dc08b2) Signed-off-by: Tesshu Flower <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-0.12 #1535 +/- ##
==============================================
+ Coverage 66.2% 66.3% +0.1%
==============================================
Files 57 57
Lines 7474 7501 +27
==============================================
+ Hits 4950 4977 +27
Misses 2236 2236
Partials 288 288
|
|
/cc @JohnStrunk |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnStrunk, tesshuflower The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1030db5
into
backube:release-0.12
26 checks passed
tesshuflower
deleted the
cherry-pick-release-0.12-1519-resourcenamelimit-63chars
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resourcenamelimit 63chars
(cherry picked from commit 9dc08b2)
Describe what this PR does
Is there anything that requires special attention?
Related issues:
#1470