Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rack dependency update #1

Open
wants to merge 3 commits into
base: core-0-8-stable
Choose a base branch
from
Open

rack dependency update #1

wants to merge 3 commits into from

Conversation

norepIy
Copy link

@norepIy norepIy commented Nov 16, 2017 •
edited
Loading

  • bumps rack requirement to 2.0, jwt to 1.5.6.
  • all tests passing.
  • PR is against the base branch that we're currently using

@norepIy norepIy changed the base branch from master to core-0-8-stable November 16, 2017 21:32
jfrancese-datto
jfrancese-datto approved these changes Nov 16, 2017
View reviewed changes
Copy link

@jfrancese-datto jfrancese-datto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dattocgernon
dattocgernon approved these changes Nov 16, 2017
View reviewed changes
Copy link

@dattocgernon dattocgernon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrancese-datto jfrancese-datto jfrancese-datto approved these changes

@dattocgernon dattocgernon dattocgernon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norepIy @dattocgernon @jfrancese-datto