fix buffer size on read; close write file on read open error; see #24

backuppc · Jul 12, 2021 · 1387fbf · 1387fbf
1 parent 3386515
commit 1387fbf
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/backuppc/bpc_poolWrite.c b/backuppc/bpc_poolWrite.c
@@ -693,10 +693,11 @@ int bpc_poolWrite_copyToPool(bpc_poolWrite_info *info, char *poolPath, char *fil
     if ( (fdRead = open(fileName, O_RDONLY)) < 0 ) {
         info->errorCnt++;
         bpc_logErrf("bpc_poolWrite_copyToPool: can't open %s for reading", fileName);
+        close(fdWrite);
         return -1;
     }
 
-    while ( (nRead = read(fdRead, info->buffer, sizeof(info->buffer))) > 0 ) {
+    while ( (nRead = read(fdRead, info->buffer, BPC_POOL_WRITE_BUF_SZ)) > 0 ) {
         uchar *p = info->buffer;
         int thisWrite;