add ssh remote connection & validator installation for sn12 #39

drunest · 2024-09-25T13:37:33Z

Add ssh remote connection without password. but it requires passphrase for the private key
Generate pre_config file based on the subnet codename
Transfer the required files to the remote server
Make .env file on the remove server based on the pre_config.json and .env.template
Run the pre_install.sh on the remote server
Run the install.sh on the remote server
Child hotkey is configurable when the validator is installed on the provision server
Add dumper commands and normalizing codename API endpoints
SECRET_KEY and POSTRES_PASSWORD are using random value

drunest · 2024-10-01T12:41:48Z

Currently, it has only generating new child hotkey based on the main hotkey
subnets.yaml file includes the codename list for normalizing the subnet_identifier
Add dumper commands and normalizing codename API endpoint. there is no authentication here right now. It would considerable in the future.

ppolewicz · 2024-10-04T20:01:48Z

app/src/auto_validator/core/admin.py

+        # change the path to the actual path of the private key
+        # change the hotkey to the actual hotkey of the validator
+        # change the IP address to the actual IP address of the server
+        # change the username to the actual username of the server
+        # change the path to the actual path of the private key
+        # change the passphrase to the actual passphrase of the private key
+        install_validator_on_remote_server(
+            subnet_slot.subnet.codename,
+            subnet_slot.blockchain,
+            subnet_slot.netuid,
+            "/root/.bittensor/wallets/validator",
+            "validator-hotkey",
+            "219.15.67.27",
+            "root",
+            "/root/.ssh/id_rsa",
+            "1234567890",
+        )


this is not ready for review, why are you submitting it for review when the first thing that I read in the PR is that this isn't finished?

ppolewicz · 2024-10-04T20:04:49Z

app/src/auto_validator/core/api.py

@@ -9,6 +12,8 @@
 from .authentication import HotkeyAuthentication
 from .utils.bot import trigger_bot_send_message

+YAML_FILE_PATH = settings.LOCAL_SUBNETS_SCRIPTS_PATH + "/subnets.yaml"


Suggested change

YAML_FILE_PATH = settings.LOCAL_SUBNETS_SCRIPTS_PATH + "/subnets.yaml"

SUBNETS_CONFIG_PATH = pathlib.Path(settings.LOCAL_SUBNETS_SCRIPTS_PATH) / "subnets.yaml"

"yaml file" is ambigous and this is a string representing a path, not a python Path object that it should be. Also you assume that the path delimiter is / which does not necessarily need to be true.

app/src/auto_validator/core/api.py

ppolewicz · 2024-10-04T21:14:07Z

app/src/auto_validator/core/utils/utils.py

+    yaml_file_path = f"{LOCAL_SUBNETS_SCRIPTS_PATH}/subnets.yaml"
+    csv_file_path = f"{LOCAL_SUBNETS_SCRIPTS_PATH}/secrets.csv"
+
+    local_hotkey_path = f"{coldkey_path}/hotkeys/{hotkey_name}"


Suggested change

local_hotkey_path = f"{coldkey_path}/hotkeys/{hotkey_name}"

local_hotkey_path = coldkey_path / 'hotkeys' / hotkey_name

ppolewicz · 2024-10-04T21:14:57Z

app/src/auto_validator/core/utils/utils.py

+            "subnet1", "mainnet", "1", "/root/.bittensor/wallets/validator/", "validator-hotkey", "29.92.12.1", "root", "/root/.ssh/id_rsa", "1234567890"
+        )
+    """
+    ssh = create_ssh_client(ssh_ip_address, ssh_user, ssh_key_path, ssh_passphrase)


this should be a context manager which will call .close() on __exit__

ppolewicz · 2024-10-04T21:15:45Z

app/src/auto_validator/core/utils/utils.py

+    ssh.close()
+
+
+def create_new_child_hotkey(netuid, wallet_name, parent_hotkey, child_hotkey, proportion):


add typing everywhere, it's not python 2.7 ;)

ppolewicz · 2024-10-04T21:16:03Z

app/src/auto_validator/core/utils/utils.py

+        proportion (float): proportion of the parent hotkey, (0, 1].
+
+    Examples:
+        create_new_child_hotkey("1", "validator", "validator-hotkey", "child-hotkey", "0.5")


Suggested change

create_new_child_hotkey("1", "validator", "validator-hotkey", "child-hotkey", "0.5")

>>> create_new_child_hotkey("1", "validator", "validator-hotkey", "child-hotkey", "0.5")

>>>

ppolewicz · 2024-10-04T21:16:57Z

app/src/auto_validator/core/utils/utils.py

+    commands = [
+        "btcli",
+        "stake",
+        "set_children",
+        "--netuid",
+        netuid,
+        "--children",
+        child_wallet.hotkey.ss58_address,
+        "--proportion",
+        proportion,
+        "--hotkey",
+        parent_wallet.hotkey.ss58_address,
+        "--wallet.name",
+        wallet_name,
+    ]
+    result = subprocess.run(commands, capture_output=True, text=True)


this should use bittensor sdk, not subprocess.run

ppolewicz · 2024-10-06T20:27:47Z

pyproject.toml

+    "paramiko>=3.5.0",
+    "scp>=0.15.0",
    "discord.py==2.4.0",
    "python-dotenv>=1.0.1",
+    "paramiko>=3.5.0",
+    "scp>=0.15.0",


Suggested change

"paramiko>=3.5.0",

"scp>=0.15.0",

"discord.py==2.4.0",

"python-dotenv>=1.0.1",

"paramiko>=3.5.0",

"scp>=0.15.0",

"discord.py==2.4.0",

"python-dotenv>=1.0.1",

"paramiko>=3.5.0",

"scp>=0.15.0",

app/src/auto_validator/core/api.py

ppolewicz · 2024-10-08T20:33:30Z

app/src/auto_validator/core/utils/childhotkey.py

+        netuid: int,
+        child_wallet_name: str,
+        child_hotkey_name: str,
+        proportion: float = 0.1,


Suggested change

proportion: float = 0.1,

proportion: float = 1,

ppolewicz · 2024-10-08T20:35:36Z

app/src/auto_validator/core/utils/childhotkey.py

+        except Exception as e:
+            self.logger.exception(f"Error while getting children hotkeys: {e}")
+            return None
+        return result


don't catch it, let it 500. Returning None is much harder to handle

ppolewicz · 2024-10-08T20:36:18Z

app/src/auto_validator/core/utils/childhotkey.py

+        except Exception as e:
+            self.logger.exception(f"Error while revoking children hotkeys: {e}")
+            return False
+        return True


let it crash

app/src/auto_validator/core/utils/ssh.py

ppolewicz · 2024-10-08T20:49:23Z

app/src/auto_validator/core/utils/utils.py

                else:
                    secrets[row["SECRET_KEYS"]] = row["SECRET_VALUES"]
    secrets["SUBNET_CODENAME"] = subnet_codename
    secrets["BITTENSOR_NETWORK"] = "finney" if blockchain == "mainnet" else "test"
+    secrets["BITTENSOR_CHAIN_ENDPOINT"] = (
+        "wss://entrypoint-finney.opentensor.ai:443"


take a value from constance, which will use finney by default

ppolewicz · 2024-10-08T20:49:39Z

app/src/auto_validator/core/utils/utils.py

+        if blockchain == "mainnet"
+        else "wss://test.finney.opentensor.ai:443"


not mainnet is not necessarily testnet, you cannot make that assumption

ppolewicz · 2024-10-08T20:50:05Z

app/src/auto_validator/core/utils/utils.py

+        origin = repo.remotes.origin
+        origin.pull("master")
+    except GitCommandError as e:
+        raise ValueError(f"Error while pulling the repository: {e}")


which repository? for which netuid?

ppolewicz · 2024-10-08T20:52:00Z

app/src/auto_validator/core/utils/utils.py

+        remote_env_template_path = f"{remote_path}.env.template"
+        remote_pre_config_path = f"{remote_path}pre_config.json"


/ should be on this side, not in the path

ppolewicz · 2024-10-08T20:52:25Z

app/src/auto_validator/core/utils/utils.py

-    print(stderr.read().decode())
-    ssh.close()
+        # Run pre_install.sh on remote server
+        # ssh_manager.execute_command(f"bash {remote_path}/install.sh")


yeah run it

ppolewicz · 2024-10-14T19:19:28Z

app/src/auto_validator/core/utils/childhotkey.py

+        sys.stdin = StringIO("y\n")
+        cli_manager.stake_revoke_children(
+            wallet_name=self.parent_wallet_name,
+            wallet_hotkey=self.parent_hotkey_name,
+            wallet_path=self.parent_wallet_path,
+            network=network,
+            netuid=netuid,
+            all_netuids=False,
+            quiet=True,
+            verbose=False,
+            wait_for_finalization=True,
+            wait_for_inclusion=True,
+        )
+        sys.stdin = sys.__stdin__


that sys.stdin thing should be in the CLIManager class, not in every single place where you are calling it

ppolewicz · 2024-10-14T19:20:20Z

app/src/auto_validator/core/utils/ssh.py

@@ -26,22 +26,19 @@ def connect(self) -> bool:
                passphrase=self.passphrase,
            )
        except Exception as e:
-            self.logger.exception(f"SSH Execute Command Error: {e}")
+            self.logger.exception("SSH Execute Command Error: %s", e)


What command execution are we logging here about?

This is a connecftion attempt, not a command

ppolewicz · 2024-10-14T19:22:32Z

app/src/auto_validator/core/utils/ssh.py

+        # Ensure local_files is a list
+        if isinstance(local_files, str):
+            local_files = [local_files]
+


Suggested change

# Ensure local_files is a list

if isinstance(local_files, str):

local_files = [local_files]

don't try to fix input, error out instead. Static code analyzer (or IDE) should be used to check types, if we really need it (not in this project though)

ppolewicz · 2024-10-14T19:24:38Z

app/src/auto_validator/core/utils/ssh.py

@@ -75,6 +76,8 @@ def copy_files_to_remote(self, local_files: str, remote_path: str) -> None:
                        break
                self.logger.info("Files copied to remote server successfully")
            except SCPException as e:
-                self.logger.exception(f"SCP Error: {e}")
+                self.logger.exception("SCP Error: %s", e)
+                raise SCPException("SCP Error: %s", e)


Suggested change

raise SCPException("SCP Error: %s", e)

raise

ppolewicz · 2024-10-14T19:24:44Z

app/src/auto_validator/core/utils/ssh.py

            except OSError as e:
-                self.logger.exception(f"IOError: {e}")
+                self.logger.exception("IOError: %s", e)
+                raise OSError("IOError: %s", e)


Suggested change

raise OSError("IOError: %s", e)

raise

ppolewicz · 2024-10-14T19:27:23Z

app/src/auto_validator/core/utils/utils.py

+        remote_env_template_path = os.path.join(remote_path, ".env.template")
+        remote_pre_config_path = os.path.join(remote_path, "pre_config.json")
+        remote_env_path = os.path.join(remote_path, ".env")


Suggested change

remote_env_template_path = os.path.join(remote_path, ".env.template")

remote_pre_config_path = os.path.join(remote_path, "pre_config.json")

remote_env_path = os.path.join(remote_path, ".env")

remote = pathlib.Path(remote_path)

remote_env_template_path = remote / ".env.template"

remote_pre_config_path = remote / "pre_config.json"

remote_env_path = remote / ".env"

ppolewicz · 2024-10-14T19:28:31Z

app/src/auto_validator/core/utils/utils.py

-        # Run pre_install.sh on remote server
-        # ssh_manager.execute_command(f"bash {remote_path}/install.sh")
+        # Run install.sh on remote server
+        remote_install_script_path = os.path.join(remote_path, "install.sh")


Suggested change

remote_install_script_path = os.path.join(remote_path, "install.sh")

remote_install_script_path = remote / "install.sh"

ppolewicz · 2024-10-14T19:30:32Z

app/src/auto_validator/core/utils/utils.py

-        # ssh_manager.execute_command(f"bash {remote_path}/install.sh")
+        # Run install.sh on remote server
+        remote_install_script_path = os.path.join(remote_path, "install.sh")
+        ssh_manager.execute_command(f"bash {remote_install_script_path}")


This returns an empty string on error and you don't check it here, so the entire operation will succeed and the user of the web interface won't know about it unless he logs into the server and inspects the logs. Unacceptable. The command should fail and the user should get a message of some sort.

ppolewicz · 2024-10-16T20:05:00Z

app/src/auto_validator/core/utils/childhotkey.py

+        result = self.cli_manager.stake_revoke_children(*args, **kwargs)
+        return result


Suggested change

result = self.cli_manager.stake_revoke_children(*args, **kwargs)

return result

with self:

result = self.cli_manager.stake_revoke_children(*args, **kwargs)

return result

and then the caller doesn't need to with but can just call a method

drunest added 20 commits September 24, 2024 12:35

feat: add validator installation scripts

fff2ba6

feat: add remote validator installation

36e6be5

chore: update script files

439a22b

feat: add remote installation

51c4e58

feat: add action of installing validator on a remote server

d565298

feat: add local scripts directory path

219687c

chore: update scrips and secret

213b0f2

chore: update pdm dependencies

02dd38f

fix: update codespell

2f02c31

fix: update script file for linter

d8c76b6

Merge branch 'master' into development

b60b338

feat: add local scripts directory path

0e5bf69

chore: update pdm dependencies

51f3d7c

fix: udpate pdm lock

af6d047

feat: codename list on config file

a4c9374

feat: dumper commands and codename api

802b818

feat: generating new child hotkey and hotkey option

4126a22

chore: pdm dependencies

2236701

chore: ruff format

30327dc

fix: store child hotkey to the model

d820370

perf: remove normalizing codename api

40c4460

ppolewicz reviewed Oct 4, 2024

View reviewed changes

ppolewicz reviewed Oct 6, 2024

View reviewed changes

drunest added 6 commits October 7, 2024 15:27

fix: delete .env.template on local scripts

408f542

refactor: separate dumper commands and view

20db475

update: creat wallet

e85643c

update: add wallet info on settings

8feec14

refactor: add ssh childhotkey class

291a4ff

perf: update utils

7031184

drunest added 11 commits October 7, 2024 15:35

fix: remove codename list

e425673

chore: update dependencies

9dc4262

chore: update chilhotkey

6667ac6

refactor: revoke conftest

cd62d68

fix: update new version of wallet

bc6c88f

fix: update test conf

944397b

fix: test config

7dea1d9

chore: update dependencies

c2582a0

test: update config

e95e9c8

fix: update scripts config path

a34b0c5

feat: add pulling scripts from github

15cea39

ppolewicz reviewed Oct 8, 2024

View reviewed changes

drunest added 6 commits October 10, 2024 07:09

update: vsubnet configuration path

c87dc95

update: log format and error handling

74a33ab

update: separate subnet scripts path and configuration file path

d0d7b9c

feat: add celery task for fetching subnet scripts periodically

0eecc4e

fix: setting variable name on util

54b6441

fix: subnet config file path

86f789f

ppolewicz reviewed Oct 14, 2024

View reviewed changes

fix: some erros on the comments

f97cd0c

ppolewicz reviewed Oct 16, 2024

View reviewed changes

fix: handling installation error

5077a80

ppolewicz approved these changes Oct 18, 2024

View reviewed changes

ppolewicz merged commit 48fce20 into bactensor:master Oct 18, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add ssh remote connection & validator installation for sn12 #39

add ssh remote connection & validator installation for sn12 #39

drunest commented Sep 25, 2024 •

edited

Loading

drunest commented Oct 1, 2024

ppolewicz Oct 4, 2024

ppolewicz Oct 4, 2024

ppolewicz Oct 4, 2024

ppolewicz Oct 4, 2024

ppolewicz Oct 4, 2024

ppolewicz Oct 4, 2024

ppolewicz Oct 4, 2024

ppolewicz Oct 6, 2024

ppolewicz Oct 8, 2024

ppolewicz Oct 8, 2024

ppolewicz Oct 8, 2024

ppolewicz Oct 8, 2024

ppolewicz Oct 8, 2024

ppolewicz Oct 8, 2024

ppolewicz Oct 8, 2024

ppolewicz Oct 8, 2024

ppolewicz Oct 14, 2024

ppolewicz Oct 14, 2024

ppolewicz Oct 14, 2024

ppolewicz Oct 14, 2024

ppolewicz Oct 14, 2024

ppolewicz Oct 14, 2024

ppolewicz Oct 14, 2024

ppolewicz Oct 14, 2024

ppolewicz Oct 16, 2024

	YAML_FILE_PATH = settings.LOCAL_SUBNETS_SCRIPTS_PATH + "/subnets.yaml"
	SUBNETS_CONFIG_PATH = pathlib.Path(settings.LOCAL_SUBNETS_SCRIPTS_PATH) / "subnets.yaml"

	local_hotkey_path = f"{coldkey_path}/hotkeys/{hotkey_name}"
	local_hotkey_path = coldkey_path / 'hotkeys' / hotkey_name

		ssh.close()


		def create_new_child_hotkey(netuid, wallet_name, parent_hotkey, child_hotkey, proportion):

	create_new_child_hotkey("1", "validator", "validator-hotkey", "child-hotkey", "0.5")
	>>> create_new_child_hotkey("1", "validator", "validator-hotkey", "child-hotkey", "0.5")
	>>>

		if blockchain == "mainnet"
		else "wss://test.finney.opentensor.ai:443"

		remote_env_template_path = f"{remote_path}.env.template"
		remote_pre_config_path = f"{remote_path}pre_config.json"

	# Ensure local_files is a list
	if isinstance(local_files, str):
	local_files = [local_files]

-        remote_env_template_path = os.path.join(remote_path, ".env.template")
-        remote_pre_config_path = os.path.join(remote_path, "pre_config.json")
-        remote_env_path = os.path.join(remote_path, ".env")
+        remote = pathlib.Path(remote_path)
+        remote_env_template_path = remote / ".env.template"
+        remote_pre_config_path = remote / "pre_config.json"
+        remote_env_path = remote / ".env"

	remote_install_script_path = os.path.join(remote_path, "install.sh")
	remote_install_script_path = remote / "install.sh"

		result = self.cli_manager.stake_revoke_children(args, *kwargs)
		return result

add ssh remote connection & validator installation for sn12 #39

add ssh remote connection & validator installation for sn12 #39

Conversation

drunest commented Sep 25, 2024 • edited Loading

drunest commented Oct 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drunest commented Sep 25, 2024 •

edited

Loading