command_line/arguments: Defined constructors, assignment operators an…

…d a destructor for arguments_t so the compiler doesn't try to auto-gen them and fail
bad-alloc-heavy-industries · Aug 19, 2023 · d8bea38 · d8bea38
1 parent 807f088
commit d8bea38
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/impl/command_line/arguments.cxx b/impl/command_line/arguments.cxx
@@ -389,6 +389,10 @@ namespace substrate::commandLine
 	// Implementation of the innards of arguments_t as otherwise we get compile errors
 	// NOLINTNEXTLINE(modernize-use-equals-default)
 	arguments_t::arguments_t() noexcept : _arguments{} { }
+	arguments_t::arguments_t(const arguments_t &arguments) noexcept : _arguments{arguments._arguments} { }
+	arguments_t::arguments_t(arguments_t &&arguments) noexcept : _arguments{std::move(arguments._arguments)} { }
+	// NOLINTNEXTLINE(modernize-use-equals-default)
+	arguments_t::~arguments_t() noexcept { }
 	size_t arguments_t::count() const noexcept
 		{ return _arguments.size(); }
 	size_t arguments_t::countMatching(const std::string_view &option) const noexcept
@@ -400,6 +404,18 @@ namespace substrate::commandLine
 	arguments_t::iterator_t arguments_t::find(const std::string_view &option) const noexcept
 		{ return _arguments.find(option); }
 
+	arguments_t &arguments_t::operator =(const arguments_t &arguments) noexcept
+	{
+		_arguments = arguments._arguments;
+		return *this;
+	}
+
+	arguments_t &arguments_t::operator =(arguments_t &&arguments) noexcept
+	{
+		_arguments = std::move(arguments._arguments);
+		return *this;
+	}
+
 	// NOLINTNEXTLINE(readability-convert-member-functions-to-static)
 	std::vector<const item_t *> arguments_t::findAll(const std::string_view &option) const noexcept
 	{

diff --git a/substrate/command_line/arguments b/substrate/command_line/arguments
@@ -52,6 +52,11 @@ namespace substrate::commandLine
 
 	public:
 		arguments_t() noexcept;
+		arguments_t(const arguments_t &arguments) noexcept;
+		arguments_t(arguments_t &&arguments) noexcept;
+		~arguments_t() noexcept;
+		arguments_t &operator =(const arguments_t &arguments) noexcept;
+		arguments_t &operator =(arguments_t &&arguments) noexcept;
 
 		[[nodiscard]] bool parseFrom(internal::tokeniser_t &lexer, const options_t &options);
 		[[nodiscard]] bool add(item_t argument) noexcept;