Fix: missing constructors and operators in substrate/console #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonmux
changed the title
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 90.38% 90.38%
=======================================
Files 47 47
Lines 3277 3277
Branches 644 644
=======================================
Hits 2962 2962
Misses 247 247
Partials 68 68
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
amyspark
approved these changes
Aug 21, 2023
|
Excellent, thank you. We'll get this merged then so we can keep chipping away at the warning list and get CI on bmpflash sorted out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we aim to fix how
printable_tis defined and how theasN_ttypes failed to properly define constructors, destructors and assignment operators, thus failing the Rule of 5 requirements on them.The goal here is to address several MSVC warnings and clang-tidy lints which indicate broken code, with the intent of getting the blackmagic-debug/bmpflash build closer to warning-free ahead of cutting releases of this library and that program.