Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: std::filesystem include issues #76

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

dragonmux
Copy link
Member

As part of getting CI for bmpflash up and working, we encountered a series of issues surrounding and getting the checks for it being enabled right. This PR seeks to improve this situation by, among other things, including the header to ensure the proper feature macros are available in <substrate/include/defs> and improve the logic for defining the guard macro.

The result should be a much more robust path to getting SUBSTRATE_ALLOW_STD_FILESYSTEM_PATH defined in appropriate circumstances.

@dragonmux dragonmux added the bug Something isn't working label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #76 (944b65b) into main (6483ea5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files          47       47           
  Lines        3277     3277           
  Branches      644      644           
=======================================
  Hits         2962     2962           
  Misses        247      247           
  Partials       68       68           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dragonmux dragonmux merged commit 944b65b into main Aug 22, 2023
168 of 169 checks passed
@dragonmux dragonmux deleted the fix/std-filesystem-include-issues branch August 22, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants