Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improved Windows console text handling #79

Merged
merged 13 commits into from
Nov 3, 2023

console: Handle Windows translating "\n" to "\r\n" on text-mode FDs

fb4dbe0
Select commit
Loading
Failed to load commit list.
Merged

Feature: Improved Windows console text handling #79

console: Handle Windows translating "\n" to "\r\n" on text-mode FDs
fb4dbe0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 3, 2023 in 0s

19.69% of diff hit (target 90.38%)

View this Pull Request on Codecov

19.69% of diff hit (target 90.38%)

Annotations

Check warning on line 94 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L94

Added line #L94 was not covered by tests

Check warning on line 98 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L97-L98

Added lines #L97 - L98 were not covered by tests

Check warning on line 103 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L103

Added line #L103 was not covered by tests

Check warning on line 105 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L105

Added line #L105 was not covered by tests

Check warning on line 107 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L107

Added line #L107 was not covered by tests

Check warning on line 110 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L109-L110

Added lines #L109 - L110 were not covered by tests

Check warning on line 116 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L116

Added line #L116 was not covered by tests

Check warning on line 122 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L122

Added line #L122 was not covered by tests

Check warning on line 125 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L125

Added line #L125 was not covered by tests

Check warning on line 128 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L128

Added line #L128 was not covered by tests

Check warning on line 217 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L217

Added line #L217 was not covered by tests

Check warning on line 221 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L220-L221

Added lines #L220 - L221 were not covered by tests

Check warning on line 225 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L223-L225

Added lines #L223 - L225 were not covered by tests

Check warning on line 228 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L228

Added line #L228 was not covered by tests

Check warning on line 232 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L232

Added line #L232 was not covered by tests

Check warning on line 237 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L237

Added line #L237 was not covered by tests

Check warning on line 239 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L239

Added line #L239 was not covered by tests

Check warning on line 246 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L242-L246

Added lines #L242 - L246 were not covered by tests

Check warning on line 252 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L252

Added line #L252 was not covered by tests

Check warning on line 258 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L256-L258

Added lines #L256 - L258 were not covered by tests

Check warning on line 264 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L262-L264

Added lines #L262 - L264 were not covered by tests

Check warning on line 268 in impl/console.cxx

See this annotation in the file changed.

@codecov codecov / codecov/patch

impl/console.cxx#L267-L268

Added lines #L267 - L268 were not covered by tests

Check warning on line 66 in substrate/console

See this annotation in the file changed.

@codecov codecov / codecov/patch

substrate/console#L66

Added line #L66 was not covered by tests