Add support for detecting unreachable code #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E:\subprojects\substrate\impl\socket.cxx(174) : warning C4715: 'substrate::socket::typeToFamily': not all control paths return a value E:\subprojects\substrate\impl\socket.cxx(200) : warning C4715: 'substrate::socket::protocolToType': not all control paths return a value E:\subprojects\substrate\impl\socket.cxx(187) : warning C4715: 'substrate::socket::protocolToHints': not all control paths return a value and another one in clangd because the flag didn't get applied.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 89.70% 89.57% -0.14%
==========================================
Files 47 47
Lines 3419 3424 +5
Branches 659 662 +3
==========================================
Hits 3067 3067
- Misses 314 321 +7
+ Partials 38 36 -2 ☔ View full report in Codecov by Sentry. |
dragonmux
reviewed
Jan 7, 2024
dragonmux
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
This is a PR to add a little feature, marking code at a certain point to be unreachable (and if so, trigger UBSan or abort).