-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
options: Add contextual value to the helper text #82
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 89.57% 89.18% -0.39%
==========================================
Files 47 47
Lines 3424 3459 +35
Branches 662 669 +7
==========================================
+ Hits 3067 3085 +18
- Misses 321 338 +17
Partials 36 36 ☔ View full report in Codecov by Sentry. |
970949a
to
bbc3039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty great! There are a couple of stylistic items we've spotted in review and a couple of queries about lambda captures, but with those addressed we're happy to get this merged.
bbc3039
to
23ef023
Compare
I've applied all the bits as requested. Let me know if anything else is needed! |
23ef023
to
1fba992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we'll get this merged once the builds complete. Thank you for the contribution!
👋
This is a PR to add a placeholder in the options' display text so that the user knows what to enter as values.