Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: Add contextual value to the helper text #82

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

amyspark
Copy link
Collaborator

@amyspark amyspark commented Jan 7, 2024

👋

This is a PR to add a placeholder in the options' display text so that the user knows what to enter as values.

@dragonmux dragonmux added the enhancement New feature or request label Jan 7, 2024
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (29962af) 89.57% compared to head (1fba992) 89.18%.

Files Patch % Lines
impl/command_line/options.cxx 51.16% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   89.57%   89.18%   -0.39%     
==========================================
  Files          47       47              
  Lines        3424     3459      +35     
  Branches      662      669       +7     
==========================================
+ Hits         3067     3085      +18     
- Misses        321      338      +17     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty great! There are a couple of stylistic items we've spotted in review and a couple of queries about lambda captures, but with those addressed we're happy to get this merged.

impl/command_line/options.cxx Outdated Show resolved Hide resolved
impl/command_line/options.cxx Outdated Show resolved Hide resolved
impl/command_line/options.cxx Outdated Show resolved Hide resolved
impl/command_line/options.cxx Outdated Show resolved Hide resolved
@amyspark
Copy link
Collaborator Author

amyspark commented Jan 9, 2024

I've applied all the bits as requested. Let me know if anything else is needed!

impl/command_line/options.cxx Outdated Show resolved Hide resolved
impl/command_line/options.cxx Outdated Show resolved Hide resolved
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll get this merged once the builds complete. Thank you for the contribution!

@dragonmux dragonmux merged commit 1fba992 into main Jan 9, 2024
165 of 167 checks passed
@amyspark amyspark deleted the amyspark/options branch January 9, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants