Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Stubs-only packages with [PypiTypes] badge #10864

Merged
merged 12 commits into from
Feb 2, 2025

Conversation

yangdanny97
Copy link
Contributor

The PypiTypes badge was added in #10774

This PR changes the badge to also check for the other typing classifier, Typing :: Stubs Only, which denotes packages that contain only type stubs (no implementation). This includes standalone stubs packages like pandas-stubs as well as the packages generated by typeshed.

If the classifier is present, the badge will show stubs (previously it showeduntyped). If both classifiers are present, the Typing :: Typed takes precedence and the badge will show typed.

Copy link
Contributor

github-actions bot commented Feb 1, 2025

Messages
📖 ✨ Thanks for your contribution to Shields, @yangdanny97!

Generated by 🚫 dangerJS against 4c0f1b6

Copy link
Contributor

github-actions bot commented Feb 2, 2025

🚀 Updated review app: https://pr-10864-badges-shields.fly.dev

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@chris48s chris48s added this pull request to the merge queue Feb 2, 2025
Merged via the queue into badges:master with commit 94909ab Feb 2, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants