-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event badging form setup #84
Conversation
@Kingscliq always reference the issue you are fixing somewhere in the commits or the comment section here so that reviewers don't confuse implementations. |
Hi @kaxada thanks for the feedback, how do I reference the issues, is there a template for that at the moment that I can look through |
Hi @Kingscliq you use the description, "This issue fixes #issuenumber". We hope to create a template soon. |
Oh thanks for the feedback @Ruth-ikegah will do just that |
13beaa6
to
1769cbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kingscliq did you intend to have it look this way or it is still a work in progress?
@kaxada It's a work in progress, working alongside @IsraelChidera on this issue |
Hi @Kingscliq great work so far on this PR. However, a little challenge because another developer is currently assigned to #82 and has been working on it. I am so sorry about this. Usually the flow is before you take up an issue, you should check if it has assigned and if not you can ask to be assigned to it. Could you work on #89 or any other issues here not assigned to anyone? I am sorry once again for the confusion. Let me know if you have any questions. |
Hi @Ruth-ikegah thanks for the clarity, is the developer you were speaking @IsraelChidera ? If it is, then we were working alongside on the issue, but if not, then it was a mistake from me. But no problem, I will start working on #89, I will tag you on it so I can be assigned |
…gscliq/badging into kingscliq-event-badging-form
Thanks for understanding @Kingscliq ! No the person is Mide. If you check the assigned section on #82. So sorry for the confusion too Chidera! @IsraelChidera you can pick other open issues too that are not assigned. I will go ahead to close this PR. |
This issue is not a fix but a setup for issue #82, the following were added to the event badging project
@Ruth-ikegah cc: @kaxada