Metro #96
Open
Metro #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badlogic
reviewed
Jun 15, 2023
| const METRO_WEBSHOP_BASE_URL = "https://shop.metro.at/shop/1"; | ||
| const METRO_API_BASE_RL = "https://api.shop.metro.at/2.0"; | ||
| const METRO_API_USER = "[email protected]"; | ||
| const METRO_API_PASSWORD = "Welcome1"; |
There was a problem hiding this comment.
Woher kommen username und password? Ich fürchte das kann ich aus rechtlichen Gründen nicht mergen.
There was a problem hiding this comment.
Das sind jene Credentials, welche die Metro App verwendet, um alle Produkte zu fetchen (selbst dann wenn man als User noch gar nicht eingeloggt ist).
PW is immer das gleiche, und die E-Mail Adresse bezeichnet eine spezifische Filiale.
Kann prinzipiell jeder, der sich die App anschaut abgreifen, also so pseudo-public würd ich meinen, aber verstehe natürlich deine Bedenken.
Alternativ kann man's vlt als Github-Secret pflegen, wenn's im Code zu heikel is.....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Just added METRO to the stores...
They list many branded products and also got their own brands, sometimes even discount brands from others such as S-Budget.
Probably not the majority of people do their groceries there, but maybe still interesting in terms of price comparison and in general, just to see how wholesale markets calculate...