Set default value of retain clean jobs flag to false (#31)

Closes #27
bakdata · Dec 21, 2022 · 32b504e · 32b504e
1 parent e13b10e
commit 32b504e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/kpops/cli/pipeline_config.py b/kpops/cli/pipeline_config.py
@@ -94,7 +94,7 @@ class PipelineConfig(BaseSettings):
         "This is used for cleaning/resettting Kafka connectors, see https://github.com/bakdata/kafka-connect-resetter",
     )
     retain_clean_jobs: bool = Field(
-        default=True,
+        default=False,
         env=f"{ENV_PREFIX}RETAIN_CLEAN_JOBS",
         description="Whether to retain clean up jobs in the cluster or uninstall the, after completion.",
     )

diff --git a/tests/components/test_kafka_connect_component.py b/tests/components/test_kafka_connect_component.py
@@ -184,7 +184,7 @@ def test_clean(self, test_config: PipelineConfig, mocker: MockerFixture):
                     connector_name="test-connector",
                     connector_type=KafkaConnectorType.SINK,
                     dry_run=True,
-                    retain_clean_jobs=True,
+                    retain_clean_jobs=False,
                     delete_consumer_group=True,
                 ),
             ]
@@ -231,7 +231,7 @@ def test_reset(self, test_config: PipelineConfig, mocker: MockerFixture):
                     connector_name="test-connector",
                     connector_type=KafkaConnectorType.SINK,
                     dry_run=True,
-                    retain_clean_jobs=True,
+                    retain_clean_jobs=False,
                     delete_consumer_group=False,
                 ),
             ]
@@ -272,7 +272,7 @@ def test_clean_without_to(self, test_config: PipelineConfig, mocker: MockerFixtu
                     connector_name="test-connector",
                     connector_type=KafkaConnectorType.SINK,
                     dry_run=True,
-                    retain_clean_jobs=True,
+                    retain_clean_jobs=False,
                     delete_consumer_group=True,
                 ),
             ]
@@ -378,7 +378,7 @@ def test_clean(self, test_config: PipelineConfig, mocker: MockerFixture):
                     connector_name="test-connector",
                     connector_type=KafkaConnectorType.SOURCE,
                     dry_run=True,
-                    retain_clean_jobs=True,
+                    retain_clean_jobs=False,
                     offset_topic="kafka-connect-offsets",
                 ),
             ]
@@ -423,7 +423,7 @@ def test_clean_without_to(self, test_config: PipelineConfig, mocker: MockerFixtu
                     connector_name="test-connector",
                     connector_type=KafkaConnectorType.SOURCE,
                     dry_run=True,
-                    retain_clean_jobs=True,
+                    retain_clean_jobs=False,
                     offset_topic="kafka-connect-offsets",
                 ),
             ]
@@ -476,7 +476,7 @@ def test_reset(self, test_config: PipelineConfig, mocker: MockerFixture):
                     connector_name="test-connector",
                     connector_type=KafkaConnectorType.SOURCE,
                     dry_run=True,
-                    retain_clean_jobs=True,
+                    retain_clean_jobs=False,
                     offset_topic="kafka-connect-offsets",
                 ),
             ]