Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: format YAML & JSON #595

Merged
merged 5 commits into from
Jan 16, 2025
Merged

style: format YAML & JSON #595

merged 5 commits into from
Jan 16, 2025

Conversation

disrupted
Copy link
Member

No description provided.

@disrupted disrupted self-assigned this Jan 16, 2025
@disrupted disrupted marked this pull request as ready for review January 16, 2025 16:15
@disrupted disrupted requested a review from tobbber January 16, 2025 16:15
tobbber
tobbber approved these changes Jan 16, 2025
View reviewed changes
Copy link

@tobbber tobbber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Should we also update the developer docs?

@disrupted
Copy link
Member Author

looks good to me. Should we also update the developer docs?

yup, I already updated it for dev https://bakdata.github.io/kpops/dev/developer/contributing/. It will be in the next release

@disrupted disrupted enabled auto-merge (squash) January 16, 2025 17:37
@disrupted disrupted merged commit 18ec312 into main Jan 16, 2025
10 of 11 checks passed
@disrupted disrupted deleted the ci/dprint-yaml branch January 16, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobbber tobbber tobbber approved these changes

Assignees

@disrupted disrupted

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@disrupted @tobbber