Skip to content

Commit

Permalink
Fix usage of
Browse files Browse the repository at this point in the history
  • Loading branch information
@raminqaf
raminqaf committed Nov 22, 2023
1 parent 78fda28 commit e70bd1b
Show file tree
Hide file tree
Showing 9 changed files with 40 additions and 28 deletions.
7 changes: 5 additions & 2 deletions charts/producer-app-cleanup-job/templates/_helpers.tpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@ If release name contains chart name it will be used as a full name.
{{- if .Values.fullnameOverride -}}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- $name := default .Values.nameOverride -}}
{{- printf "%s-clean" $name | trunc 63 | trimSuffix "-" -}}
{{- $name := default .Chart.Name .Values.nameOverride -}}
{{- if contains $name .Release.Name -}}
{{- .Release.Name | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}

Expand Down
2 changes: 1 addition & 1 deletion charts/producer-app-cleanup-job/values.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
nameOverride: bakdata-producer-app-job
fullnameOverride: bakdata-producer-app-cleanup

image: producerApp
imageTag: latest
Expand Down
15 changes: 8 additions & 7 deletions charts/producer-app/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ Alternatively, a YAML file that specifies the values for the parameters can be p
### Job

| Parameter | Description | Default |
| ---------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------ |
| `nameOverride` | The name of the Kubernetes deployment. | `bakdata-producer-app` |
|------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------------------------------|
| `fullnameOverride` | Overrides name of the Kubernetes deployment. | `bakdata-producer-app` |
| `nameOverride` | Uses `Helm-release-name + nameOverride` for Kubernetes deployment name. | `bakdata-producer-app` |
| `resources` | See https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ | see [values.yaml](values.yaml) for details |
| `annotations` | Map of custom annotations to attach to the pod spec. | `{}` |
| `labels` | Map of custom labels to attach to the pod spec. | `{}` |
Expand All @@ -36,7 +37,7 @@ Alternatively, a YAML file that specifies the values for the parameters can be p
### Image

| Parameter | Description | Default |
| ------------------ | ------------------------------------------- | ------------- |
|--------------------|---------------------------------------------|---------------|
| `image` | Docker image of the Kafka producer app. | `producerApp` |
| `imageTag` | Docker image tag of the Kafka producer app. | `latest` |
| `imagePullPolicy` | Docker image pull policy. | `Always` |
Expand All @@ -45,7 +46,7 @@ Alternatively, a YAML file that specifies the values for the parameters can be p
### Streams

| Parameter | Description | Default |
| --------------------------- | ---------------------------------------------------------------------------------------------------------- | ------- |
|-----------------------------|------------------------------------------------------------------------------------------------------------|---------|
| `streams.brokers` | Comma separated list of Kafka brokers to connect to. | |
| `streams.schemaRegistryUrl` | URL of Schema Registry to connect to. | `null` |
| `streams.config` | Configurations for your [Kafka producer app](https://kafka.apache.org/documentation/#producerconfigs). | `{}` |
Expand All @@ -55,7 +56,7 @@ Alternatively, a YAML file that specifies the values for the parameters can be p
### Other

| Parameter | Description | Default |
| ------------------------ | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------- |
|--------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------|
| `configurationEnvPrefix` | Prefix for environment variables to use that should be parsed as command line arguments. | `APP` |
| `commandLine` | Map of command line arguments passed to the producer app. | `{}` |
| `debug` | Configure logging to debug | `false` |
Expand All @@ -67,14 +68,14 @@ Alternatively, a YAML file that specifies the values for the parameters can be p
### JVM

| Parameter | Description | Default |
| ------------------------------ | -------------------------------------------------------------------------------------------------------------------------------------------- | ------- |
|--------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------|---------|
| `javaOptions.maxRAMPercentage` | https://docs.oracle.com/javase/8/docs/technotes/tools/unix/java.html#:~:text=is%20set%20ergonomically.-,%2DXX%3AMaxRAMPercentage,-%3Dpercent | `true` |
| `javaOptions.others` | List of Java VM options passed to the producer app. | `[]` |

### Service

| Parameter | Description | Default |
| ----------------- | ---------------------------------------------------------------------------------------------- | ----------- |
|-------------------|------------------------------------------------------------------------------------------------|-------------|
| `service.enabled` | Whether to create a service. This requires the definition of at least one `ports.servicePort`. | `false` |
| `service.labels` | Additional service labels. | `{}` |
| `service.type` | Service type. | `ClusterIP` |
2 changes: 1 addition & 1 deletion charts/producer-app/values.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
nameOverride: bakdata-producer-app
fullnameOverride: bakdata-producer-app

image: producerApp
imageTag: latest
Expand Down
7 changes: 5 additions & 2 deletions charts/streams-app-cleanup-job/templates/_helpers.tpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@ If release name contains chart name it will be used as a full name.
{{- if .Values.fullnameOverride -}}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- $name := default .Values.nameOverride -}}
{{- printf "%s-clean" $name | trunc 63 | trimSuffix "-" -}}
{{- $name := default .Chart.Name .Values.nameOverride -}}
{{- if contains $name .Release.Name -}}
{{- .Release.Name | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}

Expand Down
2 changes: 1 addition & 1 deletion charts/streams-app-cleanup-job/values.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
nameOverride: bakdata-streams-app-job
fullnameOverride: bakdata-streams-app-cleanup

image: streamsApp
imageTag: latest
Expand Down
Loading

0 comments on commit e70bd1b

Please sign in to comment.