Update libify to support IDF export with symlinks #770

balazsracz · 2024-02-02T01:59:52Z

Adds two features to libify.sh:

adds support for creating or updating an OpenMRNIDF repository. This means skipping arduino-specific stuff, like examples or OpenMRNLite.h, rpelacing the readme.md and library.properties files with a different one.
Adds support for creating relative symlinks. This allows using OpenMRNIDF that links back to openmrn using relative symlinks -- these can be checked into git for example.
Adds the few toplevel files for OpenMRNIDF like cmakefile

atanisoft · 2024-02-02T13:48:38Z

arduino/libify.sh

-copy_file . arduino/{library.json,library.properties,keywords.txt,README.md,LICENSE,CONTRIBUTING.md}
-copy_dir . arduino/examples
+if [ "x$TARGET_IDF" == "x" ]; then
+    copy_file . arduino/{library.json,library.properties,keywords.txt,README.md,LICENSE,CONTRIBUTING.md}


we should probably have README.md,LICENSE,CONTRIBUTING.md on the IDF side, perhaps a slightly different version though.

I didn't add contributing.md because you don't have it, and the arduino version references the OpenMRNLite library in the text. So we'd need to first write a new one, but this is really not high priority now.

atanisoft · 2024-02-02T16:25:54Z

arduino/libify.sh

    echo '(options must come after the path specification)'
    echo '-f will erase the target library before exporting.'
    echo '-l will create symlinks instead of copying files.'
+    echo '-i will create OpenMRNIDF repository instead of arduino.'
+    echo '-r will create relative symlinks. OPenMRNPath has to be a relative path from the library export directoty back to openmrn, starting with ../'


OPenMRNPath -> OpenMRNPath
directoty -> directory

atanisoft · 2024-02-02T16:28:01Z

arduino/libify.sh

+if [ "x$TARGET_IDF" == "x" ]; then
+    copy_file . arduino/{library.json,library.properties,keywords.txt,README.md,LICENSE,CONTRIBUTING.md}
+    copy_dir . arduino/examples
+fi

 copy_file src arduino/OpenMRNLite.{h,cpp} arduino/CDIXMLGenerator.hxx \


Should we consider moving arduino/OpenMRNLite.{h,cpp} to the arduino block above since these have arduino dependencies?

You have them in your repo. I guess you don't need it and never build it via cmake?

I think they came over as a mass import from the exported tree create by the script. They are excluded from build via cmake: https://github.com/atanisoft/OpenMRNIDF/blob/5.1.0/CMakeLists.txt except when CONFIG_ENABLE_ARDUINO_DEPENDS is set (for IDF+Arduino builds which doesn't make much sense really)

* master: Fix esp32 select race conditions. (#780) Latency test with maximum stats and custom process evaluation (#773) Fix compiler warnings in openmrn when using new GCC's. (#772) Upintegrate changes from the OpenMRNIDF repository (#771) Adds support for DCC extended accessories (#769) Fix incorrect consumer identified message being emitted by dcc accy producer. (#768) Avoids rendering hidden segments. (#767) Adds trailing zero to the cdi XML file written to the filesystem. (#777) Fix target subdirectory name (#775) Fixes file comment. Adds an application (hub_test) for testing the throughput of a hub or a CAN-bus (#762) Adds a helper function to decode a 14-bit 9.2.1.1 address into address type and raw address. (#766) Fix broken test. Accessory packet refactoring and POM support (#764)

…t-hub-router # By Balazs Racz (26) and others * 'master' of github.com:bakerstu/openmrn: (28 commits) Fix build of esp8266 train implementation. Removes unnecessary includes that might not exist on an embedded compiler. Fix compilation of TempFile under esp8266. Add libatomic to esp8266 nonos target. Fix compile errors in time_client app. Fixes in file memory space: (#786) Change startup state to stopped. (#784) Fixes write code for spiflash. (#782) Handles bus passive in TivaCan. (#781) Update libify to support IDF export with symlinks (#770) Fix esp32 select race conditions. (#780) Latency test with maximum stats and custom process evaluation (#773) Fix compiler warnings in openmrn when using new GCC's. (#772) Upintegrate changes from the OpenMRNIDF repository (#771) Adds support for DCC extended accessories (#769) Fix incorrect consumer identified message being emitted by dcc accy producer. (#768) Avoids rendering hidden segments. (#767) Adds trailing zero to the cdi XML file written to the filesystem. (#777) Fix target subdirectory name (#775) Fixes file comment. ... # Conflicts: # src/utils/constants.cxx # src/utils/sources

* bracz-direct-hub-router: (35 commits) High-performance hub component for dealing with many sockets and high throughput (#760) Fix test build. Fixed comment and adds a todo. Remove unnecessary log. Fix comments and reduce unnecessary log level. FIx comments. Fix build of esp8266 train implementation. Removes unnecessary includes that might not exist on an embedded compiler. Fix compilation of TempFile under esp8266. Add libatomic to esp8266 nonos target. Fix compile errors in time_client app. Fixes in file memory space: (#786) Change startup state to stopped. (#784) Fixes write code for spiflash. (#782) Handles bus passive in TivaCan. (#781) Update libify to support IDF export with symlinks (#770) Fix esp32 select race conditions. (#780) Latency test with maximum stats and custom process evaluation (#773) Fix compiler warnings in openmrn when using new GCC's. (#772) Upintegrate changes from the OpenMRNIDF repository (#771) ...

balazsracz added 2 commits February 1, 2024 17:56

Adds support for updating an openmrnidf repo instead of an android repo.

78be775

Adds support for creating relative symlinks to openmrn source tree.

e7b08d8

atanisoft reviewed Feb 2, 2024

View reviewed changes

balazsracz added 3 commits February 4, 2024 19:57

Adds additional toplevel files that OpenMRNIDF needs.

1db8f18

Fixes comments.

9961871

balazsracz merged commit 7a842f3 into master Feb 5, 2024
8 checks passed

balazsracz deleted the bracz-libify-update branch February 5, 2024 04:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update libify to support IDF export with symlinks #770

Update libify to support IDF export with symlinks #770

balazsracz commented Feb 2, 2024 •

edited

Loading

atanisoft Feb 2, 2024

balazsracz Feb 5, 2024

balazsracz Feb 5, 2024

atanisoft Feb 2, 2024 •

edited

Loading

balazsracz Feb 5, 2024

atanisoft Feb 2, 2024

balazsracz Feb 2, 2024

atanisoft Feb 2, 2024 •

edited

Loading

balazsracz Feb 5, 2024

Update libify to support IDF export with symlinks #770

Update libify to support IDF export with symlinks #770

Conversation

balazsracz commented Feb 2, 2024 • edited Loading

atanisoft Feb 2, 2024

Choose a reason for hiding this comment

balazsracz Feb 5, 2024

Choose a reason for hiding this comment

balazsracz Feb 5, 2024

Choose a reason for hiding this comment

atanisoft Feb 2, 2024 • edited Loading

Choose a reason for hiding this comment

balazsracz Feb 5, 2024

Choose a reason for hiding this comment

atanisoft Feb 2, 2024

Choose a reason for hiding this comment

balazsracz Feb 2, 2024

Choose a reason for hiding this comment

atanisoft Feb 2, 2024 • edited Loading

Choose a reason for hiding this comment

balazsracz Feb 5, 2024

Choose a reason for hiding this comment

balazsracz commented Feb 2, 2024 •

edited

Loading

atanisoft Feb 2, 2024 •

edited

Loading

atanisoft Feb 2, 2024 •

edited

Loading