Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes missing translation of enums when reading the security mode from a simplelink profile. #796

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

balazsracz
Copy link
Collaborator

@balazsracz balazsracz commented Aug 19, 2024

The external enum is not the same as the internal enum. We have translation functions security_type_from_simplelink and security_type_to_simplelink. We forgot to call this function on one of the codepaths.

Updates the setup_ap function to be able to be called with nullptr as ssid and security key, to just update the security type.

@balazsracz balazsracz merged commit c8f2cbd into master Aug 20, 2024
4 checks passed
@balazsracz balazsracz deleted the bracz-security-read-fix branch August 20, 2024 13:39
balazsracz added a commit that referenced this pull request Aug 20, 2024
* master:
  Bug fixes in DataBuffer (#791)
  Fixes race conditions in HubDeviceSelect. (#795)
  Fixes missing translation of enums when reading the security mode from a simplelink profile. (#796)
  Fixes flaky IfCanStress.test. (#794)
balazsracz added a commit that referenced this pull request Aug 22, 2024
* master:
  Fixes a standards compliance issue with the alias conflict handler. (#793)
  Bug fixes in DataBuffer (#791)
  Fixes race conditions in HubDeviceSelect. (#795)
  Fixes missing translation of enums when reading the security mode from a simplelink profile. (#796)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants