Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove staking from the Balanced token #470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AntonAndell
Copy link
Collaborator

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@TRSSMG
Copy link
Collaborator

TRSSMG commented Dec 5, 2024

You intentionally kept the DB variables or just missed it to remove?

@AntonAndell
Copy link
Collaborator Author

You intentionally kept the DB variables or just missed it to remove?

Forgot to remove

@TRSSMG
Copy link
Collaborator

TRSSMG commented Dec 5, 2024

You intentionally kept the DB variables or just missed it to remove?

Forgot to remove

Also constants, status. And Unit tests yet to be updated?

@AntonAndell AntonAndell force-pushed the feat/remove-baln-staking branch from 08fc732 to b3cf4d2 Compare December 5, 2024 11:11
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.55%. Comparing base (094861e) to head (b3cf4d2).

Files with missing lines Patch % Lines
.../score/tokens/balancedtoken/BalancedTokenImpl.java 15.78% 15 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #470      +/-   ##
============================================
- Coverage     73.06%   72.55%   -0.51%     
+ Complexity     1617     1554      -63     
============================================
  Files           120      120              
  Lines          7752     7467     -285     
  Branches        935      897      -38     
============================================
- Hits           5664     5418     -246     
+ Misses         1681     1664      -17     
+ Partials        407      385      -22     
Flag Coverage Δ
java 72.55% <15.78%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntonAndell AntonAndell changed the title WIP feat: Remove staking from the Balanced token Dec 6, 2024
@AntonAndell AntonAndell added the enhancement New feature or request label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants