Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to deploy 9 #429

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Update to deploy 9 #429

merged 5 commits into from
Oct 9, 2024

Conversation

MattPereira
Copy link
Member

@MattPereira MattPereira commented Oct 8, 2024

You know what it is 🤣

Comment on lines +217 to +218
export const BALANCER_COMPOSITE_LIQUIDITY_ROUTER: Record<number, Address> = {
[ChainId.SEPOLIA]: '0x89cA59Bc46c00D90C496Fc99f16668b00Dd6B5CC',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this to help prepare for the upcoming boosting / nesting

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this too

@@ -24,7 +24,7 @@ export default defineConfig(({ mode }) => {
},
test: {
testTimeout: 20_000,
hookTimeout: 30_000,
hookTimeout: 60_000,
Copy link
Member Author

@MattPereira MattPereira Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see by the commits on this PR, the create pool tests I just refactored will timeout on ~half the attempts. I think because I moved pool creation into the beforeAll hook. Thought it made sense to re-use same pool when testing deployment and initialization, but let me know if this is bad practice or if it is important to keep hook timeout at 30s

poolAddress = await doCreatePool({
client,
testAddress,
createPoolInput,
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests have always been a pain! Not sure if we're missing something but haven't had time to check yet. Lets see how it goes for now.

Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt.

@MattPereira MattPereira merged commit c00da93 into main Oct 9, 2024
4 checks passed
@MattPereira MattPereira mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants