-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to deploy 9 #429
Update to deploy 9 #429
Conversation
export const BALANCER_COMPOSITE_LIQUIDITY_ROUTER: Record<number, Address> = { | ||
[ChainId.SEPOLIA]: '0x89cA59Bc46c00D90C496Fc99f16668b00Dd6B5CC', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this to help prepare for the upcoming boosting / nesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this too
@@ -24,7 +24,7 @@ export default defineConfig(({ mode }) => { | |||
}, | |||
test: { | |||
testTimeout: 20_000, | |||
hookTimeout: 30_000, | |||
hookTimeout: 60_000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you can see by the commits on this PR, the create pool tests I just refactored will timeout on ~half the attempts. I think because I moved pool creation into the beforeAll
hook. Thought it made sense to re-use same pool when testing deployment and initialization, but let me know if this is bad practice or if it is important to keep hook timeout at 30s
b-sdk/test/v3/createPool/stable/stable.integration.test.ts
Lines 84 to 88 in 9768175
poolAddress = await doCreatePool({ | |
client, | |
testAddress, | |
createPoolInput, | |
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests have always been a pain! Not sure if we're missing something but haven't had time to check yet. Lets see how it goes for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Matt.
You know what it is 🤣