Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop in replacement for pool data via multicall #90

Closed
wants to merge 2 commits into from

Conversation

gmbronco
Copy link
Contributor

Adding multicall source for getting pool's on chain data. It's meant as a drop-in replacement for the current queries contract. Would appreciate pointers where the pools query was failing so we can double check if multicall works as expected.

@johngrantuk
Copy link
Member

@gmbronco I made the changes to allow us to add Fantom config in this PR and came across the issues:

getPoolData call would randomly fail. Seems to be related to number of pools although the error message changed over a certain amount. I saw the following result consistently:

  • Up to 370 pools - ok
  • 371 pools - Error: "RPC Request failed, execution reverted"
  • 380 pools - Error: "out of gas"
    I tried a few different RPC endpoints and all seemed the same.
    Also to rule out a specific pool at index>370 causing issues I tried from index: 300->End and it ran ok.
    One day it failed almost every time but another it seems to be much less.

Also there is an ongoing issue on zkEVM so would be interesting to see if this works there too.

@gmbronco
Copy link
Contributor Author

how do i reproduce, do you use any specific subgraph query and chain?

@johngrantuk
Copy link
Member

Closing in favour of #101 which fixes issues and makes replacement

@johngrantuk johngrantuk deleted the pool-data-multicall branch October 11, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants