Exit Pool #93
Merged
Exit Pool #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmkm
reviewed
Sep 20, 2023
| return { | ||
| minAmountsOut: Array(tokens.length).fill(0n), | ||
| tokenOutIndex: tokens.findIndex( | ||
| (t) => t.address === input.tokenOut.toLowerCase(), |
There was a problem hiding this comment.
Would try to move sanitizing of input outside of the individual implementations. This isn't something we want to remember to do at this level, imo.
There was a problem hiding this comment.
Thanks for the pointer, added isSameAddress to Token implementation.
There was a problem hiding this comment.
This is fine, but it'd be nicer if sanitize happened before it ever got to weightedExit, so we don't even need to worry about this.
danielmkm
reviewed
Sep 20, 2023
|
Did a small refactor to show how we can create an intermediate layer to move some of the duplicate logic that will be in all exit types to a higher level. #96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.