Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review unsafe casts #181

Closed
jubeira opened this issue Dec 1, 2023 · 1 comment · Fixed by #978
Closed

Review unsafe casts #181

jubeira opened this issue Dec 1, 2023 · 1 comment · Fixed by #978
Milestone
Cleanup

Comments

@jubeira
Copy link
Contributor

jubeira commented Dec 1, 2023

See comments in Vault regarding casts in events:

// TODO No they aren't anymore (stored as uint112)! Review this.
@jubeira jubeira added this to the Cleanup milestone Dec 1, 2023
@jubeira jubeira mentioned this issue Dec 1, 2023
Merged
11 tasks
@EndymionJkb
Copy link
Collaborator

Comments are no longer there, and we nearly always use SafeCast now anyway with anything that has user input. There is an "unsafeCast" function we use, but that is working with max uint128 balances going to uint256. I did find one place where we were casting a timestamp without checking. (We do it in tests, but that's fine.)

@EndymionJkb EndymionJkb mentioned this issue Sep 14, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Cleanup
Development

Successfully merging a pull request may close this issue.

Safe cast stragglers balancer/balancer-v3-monorepo
2 participants
@EndymionJkb @jubeira