Safe cast stragglers #978
Merged
Safe cast stragglers #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/vault/test/.contract-sizes/VaultAdmin
# Conflicts: # pkg/pool-weighted/test/gas/.hardhat-snapshots/[WeightedPool - ERC4626 - BatchRouter] swapExactIn - no buffer liquidity - warm slots # pkg/pool-weighted/test/gas/.hardhat-snapshots/[WeightedPool - Standard] add liquidity single token exact out - warm slots # pkg/pool-weighted/test/gas/.hardhat-snapshots/[WeightedPool - Standard] add liquidity unbalanced - warm slots # pkg/vault/test/.contract-sizes/VaultAdmin
jubeira
reviewed
Sep 21, 2024
| @@ -14,6 +16,8 @@ pragma solidity ^0.8.24; | |||
| * When the buffer period expires, it will unpause automatically, and remain permissionless forever after. | |||
| */ | |||
| contract FactoryWidePauseWindow { | |||
| using SafeCast for *; | |||
There was a problem hiding this comment.
Hmm where are we using this?
There was a problem hiding this comment.
Removed... it was used to case the timestamp in the getNewPoolPauseWindowEndTime function, but then I realized that would revert when it overflowed (in 2106, but still...), but the inequality would still work, so as it is now it will return 0 after 2106 instead of reverting, as it should. No longer needed the cast, but forgot to remove it.
Truncating is worse - it could re-pause itself after 2106.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looking through the issues, was about to close 181 (since the comment it references is long gone), and thought I'd check for any unsafe casts. We'd recently gone through and added SafeCasts as a result of auditor comments. There were a couple very obscure cases still uncovered (outside tests).
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution
Closes #181