Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity 0.8.27 #954

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Solidity 0.8.27 #954

wants to merge 6 commits into from

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Sep 4, 2024

Description

Not much difference wrt. 0.8.26 in terms of the overall result really.
The main difference is that it does compile VaultExplorer as expected. Other than that, we still need the original optimization sequence.

Another observation is that if we were to change reverts for require we would need this to compile forge tests properly (in 0.8.26 require with custom errors does not work with the legacy pipeline).

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Base automatically changed from solidity-0.8.26 to main September 4, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant