Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Math libraries conform to current conventions #981

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

EndymionJkb
Copy link
Collaborator

Description

Remove stale/leftover/incorrect comments from StableMath, and essentially de-v2 it. No code changes (well, except for one event didn't track the rename of its associated function).

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • [N/A] Complex code has been commented, including external interfaces
  • [N/A] Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

@EndymionJkb EndymionJkb changed the title Make StableMath conform to current conventions Make Math libraries conform to current conventions Sep 17, 2024
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EndymionJkb EndymionJkb merged commit 9c41c3e into main Sep 18, 2024
12 checks passed
@EndymionJkb EndymionJkb deleted the stable-comment branch September 18, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants