feat: show alert when detecting API errors (in pool and pool list pages) #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
garethfuller
requested changes
Jul 10, 2024
Yeah, I won't have time to do that until next week so I pushed this ticket as an initial iteration. |
|
@alter-eggo This PR became stale but If you need a global alert for your tasks this week you can see them working in this debug page: |
|
Partially covered by #1031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects API errors in pool list and pool detail pages:
This is a first iteration. We should improve alert position and styles.
When catching
ApolloErrorin pool list page:When catching
ApolloErrorin pool detail page: