Yarn integration #373
Merged
Yarn integration #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghiant2710
force-pushed
the
yarn-integration
branch
from
760009b to
089d1b5
Compare
nghiant2710
force-pushed
the
yarn-integration
branch
2 times, most recently
from
335a069 to
898b9c9
Compare
petrosagg
approved these changes
Apr 25, 2018
petrosagg
suggested changes
Apr 25, 2018
| && for key in \ | ||
| 6A010C5166006599AA17F08146C2130DFD2497F5 \ | ||
| ; do \ | ||
| gpg --keyserver pgp.mit.edu --recv-keys "$key" || \ |
There was a problem hiding this comment.
Why do you fetch the key from multiple key servers?
There was a problem hiding this comment.
@petrosagg, I get this from upstream dockerfile, I think they do that since a key server might not be available all the time. It happens a lot in our builds when a build fails due to a key server was unreachable
shaunmulligan
approved these changes
May 1, 2018
nghiant2710
force-pushed
the
yarn-integration
branch
from
cf817a1 to
54b8618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206, yarn has been integrated into the upstream base images for a while so we should have it in our base images too.
This is the package size on amd64 base images so I think it will no longer be an issue to us anymore.