Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Node 20 #11

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Update to Node 20 #11

merged 3 commits into from
Feb 7, 2025

Conversation

cywang117
Copy link
Contributor

Change-type: patch

@pipex pipex force-pushed the upgrade-to-node-20 branch 5 times, most recently from 656b487 to 8d27f7f Compare October 21, 2024 17:48
@pipex pipex mentioned this pull request Oct 23, 2024
Open
@pipex pipex force-pushed the upgrade-to-node-20 branch 9 times, most recently from 955f73f to 8d27f7f Compare November 11, 2024 13:33
@splitice
Copy link

As per balena-os/balena-supervisor#2356 you can build node in QEMU now with a newer version of QEMU (9.1.1 tested)

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@pipex pipex force-pushed the upgrade-to-node-20 branch from e234821 to be48c14 Compare November 22, 2024 14:22
pipex added a commit to product-os/flowzone that referenced this pull request Nov 22, 2024
@pipex
Update qemu to 9.1.2
d6ea03c 
We need the new version to get the fix for https://gitlab.com/qemu-project/qemu/-/issues/1729
which is blocking balena-io-modules/node-systemd#11

Change-type: patch
Relates-to: balena-os/balena-supervisor#2356
@pipex pipex mentioned this pull request Nov 22, 2024
Closed
pipex added a commit to product-os/flowzone that referenced this pull request Dec 2, 2024
@pipex
Update qemu to 9.1.1
a8df26b 
We need the new version to get the fix for https://gitlab.com/qemu-project/qemu/-/issues/1729
which is blocking balena-io-modules/node-systemd#11

Change-type: patch
Relates-to: balena-os/balena-supervisor#2356
@pipex pipex force-pushed the upgrade-to-node-20 branch 6 times, most recently from 0a722dd to 7bfb08a Compare February 4, 2025 13:57
@pipex
Copy link
Collaborator

pipex commented Feb 4, 2025 •
edited
Loading

This is still blocked blocked by nodejs/docker-node#1946. The npm install command hangs forever on armv6 and armv7 alpine image builds using QEMU 9.2.0

@pipex pipex force-pushed the upgrade-to-node-20 branch from 7bfb08a to e1c9d96 Compare February 4, 2025 14:23
@pipex pipex force-pushed the upgrade-to-node-20 branch 3 times, most recently from 0540a05 to 5732a16 Compare February 5, 2025 15:24
@cywang117 @pipex
Update to Node 20
1d47ed8 
Change-type: patch
Signed-off-by: Christina Ying Wang <[email protected]>
@pipex pipex force-pushed the upgrade-to-node-20 branch from 5732a16 to 1d47ed8 Compare February 5, 2025 15:33
@pipex
Copy link
Collaborator

pipex commented Feb 5, 2025

This is still blocked blocked by nodejs/docker-node#1946. The npm install command hangs forever on armv6 and armv7 alpine image builds using QEMU 9.2.0

Switching to ARM runners unblocks this PR

@pipex pipex force-pushed the upgrade-to-node-20 branch 5 times, most recently from 071ad2d to 946027c Compare February 5, 2025 22:04
@pipex pipex force-pushed the upgrade-to-node-20 branch 5 times, most recently from f48b255 to 6e2104a Compare February 6, 2025 16:01
@pipex pipex marked this pull request as draft February 7, 2025 19:25
@pipex pipex force-pushed the upgrade-to-node-20 branch 6 times, most recently from 38c10e7 to decbb6d Compare February 7, 2025 20:20
@pipex pipex force-pushed the upgrade-to-node-20 branch from decbb6d to 2678abe Compare February 7, 2025 20:33
@pipex pipex marked this pull request as ready for review February 7, 2025 20:46
@pipex pipex merged commit ae652fe into main Feb 7, 2025
58 checks passed
@pipex pipex deleted the upgrade-to-node-20 branch February 7, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klutchell klutchell klutchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cywang117 @splitice @pipex @klutchell