Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: dedupe on ci #2843

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

patch: dedupe on ci #2843

wants to merge 1 commit into from

Conversation

aethernet
Copy link
Contributor

run npm dd as a postinstall step

@thgreasi
Copy link
Member

thgreasi commented Oct 8, 2024

I don't think that's a good idea, since postinstall runs on consumer's side as well
See: https://docs.npmjs.com/cli/v9/using-npm/scripts

@flowzone-app flowzone-app bot enabled auto-merge October 8, 2024 12:41
@aethernet
Copy link
Contributor Author

@thgreasi why is that a problem?

@thgreasi
Copy link
Member

thgreasi commented Oct 8, 2024

@aethernet for first it will slow down npm i -g balena-cli considerably, and it will also potentially update the local dependencies thus having them diverge from the ones that the shrinkwrap included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants