CI: Replace pgsanity with libpg-query

[joshbwlng]

Replacing pgsanity as it hasn't been updated in several years and is unable to properly parse JSON operators.

Change-type: patch
Signed-off-by: Josh Bowling [email protected]

---

libpg-query repo: https://github.com/pyramation/libpg-query-node
Issue regarding pgsanity's inability to parse JSON operators: markdrago/pgsanity#29

While libpg-query returns a full parse tree for the given SQL statement, I only real care that it throws when it fails to parse the SQL its given. This is similar to what we currently get from pgsanity, making it essentially a drop-in replacement that is more active (updated last month vs pgsanity being updated ~5 years ago) and is able to parse more recent operators etc.

Also adding an extra block to the SQL validity test to check async migration TypeScript files.

[fisehara]

looks real good to me.
I wonder if we want to move the migraton sanity check into pinejs and give it just the model configuration That we we may not need it in open-balena-api and balena-api

[joshbwlng]

@fisehara I was struggling with that myself. We did something similar in AutumnDB, add testing utilities to the lowest part of the stack that made sense and then have consumers at the higher parts of the stack use the shared utility. Is that basically what you mean?

[fisehara]

@joshbwlng Yes right. Have it in pinejs and let the model / config checked by pinejs. Basically, pinejs will run them, right?

[joshbwlng]

@fisehara Yeah, more or less. I'm not sure what that would look like exactly in pinejs, but I'm wondering if that could wait for a later PR? My main goal here is to just replace the outdated pgsanity, and ensure that async migration sql is checked (when possible). I agree that it might make sense to abstract shared testing utilities/methods, but I'd rather not let that block this work unless its super quick and easy to implement in pinejs.

[fisehara]

@joshbwlng it's absolutely fine to have it on a later PR and move it down the stack into pinjs later. Just wondered, if there is anything that would block it from this current perspective.
From my side LGTM

[joshbwlng]

@balena-ci rebase

[joshbwlng]

@balena-ci I self certify!