use github app installation token for device repository cloning #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcooke-warwick
had a problem deploying
to
balena-staging.com
GitHub Actions
Error
klutchell
reviewed
Oct 1, 2024
| - name: Create GitHub App installation token | ||
| uses: actions/create-github-app-token@5d869da34e18e7287c1daad50e0b8ea0f506ce69 # v1.11.0 | ||
| id: app-token | ||
| if: vars.FLOWZONE_APP_ID != '' | ||
| with: | ||
| app-id: ${{ vars.FLOWZONE_APP_ID }} | ||
| private-key: ${{ secrets.GH_APP_PRIVATE_KEY }} | ||
| owner: ${{ github.repository_owner }} |
There was a problem hiding this comment.
I think the owner is the current org by default, does this actually change anything?
There was a problem hiding this comment.
@klutchell if no owner arg is provided the docs say it defaults to repo only scope: https://github.com/actions/create-github-app-token/tree/5d869da34e18e7287c1daad50e0b8ea0f506ce69/?tab=readme-ov-file#create-a-token-for-the-current-repository
Logs on the step in action also show this:
"Run actions/create-github-app-token@5d869da
owner and repositories not set, creating token for the current repository ("balena-raspberrypi")"
There was a problem hiding this comment.
actually wait, it looks like my owner arg is ignored in this PR run
There was a problem hiding this comment.
ignore me ^ I put it in the wrong place, (leviathan token) , fixing
There was a problem hiding this comment.
ok confirmed, now we get an org wide token
Run actions/create-github-app-token@5d869da34e18e7287c1daad50e0b8ea0f506ce69
repositories not set, creating token for all repositories for given owner "balena-os"
There was a problem hiding this comment.
will test on a device repo. EDIT: works :)
rcooke-warwick
force-pushed
the
ryan/app-token
branch
from
f35eb7f to
4d7dbc0
Compare
rcooke-warwick
temporarily deployed
to
balena-staging.com
GitHub Actions
Inactive
rcooke-warwick
force-pushed
the
ryan/app-token
branch
from
4d7dbc0 to
ce72de8
Compare
rcooke-warwick
temporarily deployed
to
balena-staging.com
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
rcooke-warwick
force-pushed
the
ryan/app-token
branch
from
ce72de8 to
81f3978
Compare
rcooke-warwick
temporarily deployed
to
balena-staging.com
GitHub Actions
Inactive
klutchell
approved these changes
Oct 1, 2024
rcooke-warwick
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
rcooke-warwick
had a problem deploying
to
balena-cloud.com
GitHub Actions
Failure
vipulgupta2048
approved these changes
Oct 1, 2024
This is required for cloning private submodules - as the default behaviour means the token is scoped only to the repository the workflow is running on Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
rcooke-warwick
force-pushed
the
ryan/app-token
branch
from
81f3978 to
8eff76f
Compare
rcooke-warwick
temporarily deployed
to
balena-staging.com
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
rcooke-warwick
had a problem deploying
to
balena-cloud.com
GitHub Actions
Error
rcooke-warwick
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for cloning private submodules - as the default behaviour means the token is scoped only to the repository the workflow is running on
Change-type: patch